Print TypeId as hex for debugging
#127179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In <rust-lang#127134>, the `Debug` impl for `TypeId` was changed to print a single integer rather than a tuple. Change this again to print as hex for more concise and consistent formatting, as was suggested. Result: TypeId(0x1378bb1c0a0202683eb65e7c11f2e4d7)
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Jun 30, 2024
| impl fmt::Debug for TypeId { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> Result<(), fmt::Error> { | ||
| f.debug_tuple("TypeId").field(&self.as_u128()).finish() | ||
| write!(f, "TypeId({:#034x})", self.as_u128()) |
There was a problem hiding this comment.
Shouldn't this be 32 instead of 34?
There was a problem hiding this comment.
The number has to include the leading 0x when used with #. Which always feels pretty weird to me because it pads the number after the 0x, but is apparently correct (e.g. the example in the top post)
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #127134, the
Debugimpl forTypeIdwas changed to print a single integer rather than a tuple. Change this again to print as hex for more concise and consistent formatting, as was suggested.Result:
r? @Nilstrieb