crashes: readme: add reminder to add Fixes #abcde to prs to automatically close issues. #123973
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
the
S-waiting-on-review
tests/crashes/README.md
Outdated
| Adding | ||
| Fixes #12456 | ||
| Fixes #98765 | ||
| to the commit message or title of your pull request will ensure the |
There was a problem hiding this comment.
| to the commit message or title of your pull request will ensure the | |
| to the description of your pull request will ensure the |
Putting it in the title is considered bad style cuz it's not clickable, not descriptive and may lead to ppl not adding a proper title.
Furthermore, I don't think GH recognizes them in the title. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#about-linked-issues-and-pull-requests only mentions the PR description.
There was a problem hiding this comment.
Ah, and putting it in the commit message is also not great because GH continuously “mentions” such issues on rebases.
There was a problem hiding this comment.
Ah yes sorry, I mean this "body"/"header" or whatever this is called? (the first comment contains the commit message by default)
|
@bors rollup |
tests/crashes/README.md
Outdated
| Fixes #12456 | ||
| Fixes #98765 |
There was a problem hiding this comment.
| Fixes #12456 | |
| Fixes #98765 | |
| Fixes #NNN. | |
| Fixes #MMM. |
Personally speaking I like placeholders like NNN more but whatever doesn't matter.
…ally close issues.
matthiaskrgr
force-pushed
the
crashs_fix_cmt
branch
from
f1c5486 to
83d73e4
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
Rollup of 7 pull requests Successful merges: - rust-lang#123016 (Remove `TypeVariableOriginKind` and `ConstVariableOriginKind`) - rust-lang#123462 (Cleanup: Rename `ModSep` to `PathSep`) - rust-lang#123603 (Don't even parse an intrinsic unless the feature gate is enabled) - rust-lang#123926 (Fix pretty HIR for anon consts in diagnostics) - rust-lang#123973 (crashes: readme: add reminder to add Fixes #abcde to prs to automatically close issues.) - rust-lang#123984 (sanitizers: Add rustc_sanitizers to triagebot.toml) - rust-lang#123989 (Just use `type_dependent_def_id` to figure out what the method is for an expr) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#123973 - matthiaskrgr:crashs_fix_cmt, r=fmease crashes: readme: add reminder to add Fixes #abcde to prs to automatically close issues.
No description provided.