Remove TypeVariableOriginKind and ConstVariableOriginKind
#123016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in match lowering cc @Nadrieril Some changes occurred in need_type_info.rs cc @lcnr Some changes occurred in src/tools/clippy cc @rust-lang/clippy Type relation code was changed Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
rustbot
added
the
WG-trait-system-refactor
This comment has been minimized.
This comment has been minimized.
compiler-errors
force-pushed
the
no-type-var-origin
branch
from
8bb5d4d to
c6bcf4d
Compare
|
☔ The latest upstream changes (presumably #123147) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
no-type-var-origin
branch
from
c6bcf4d to
101195c
Compare
lcnr
reviewed
Mar 30, 2024
lcnr
reviewed
Mar 30, 2024
lcnr
reviewed
Mar 30, 2024
lcnr
reviewed
Mar 30, 2024
compiler-errors
force-pushed
the
no-type-var-origin
branch
2 times, most recently
from
4ef1df1 to
7dead92
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 6, 2024
…, r=lcnr Remove `TypeVariableOriginKind` and `ConstVariableOriginKind` It's annoying to have to import `TypeVariableOriginKind` just to fill it with `MiscVariable` for almost every use. Every other usage other than `TypeParameterDefinition` wasn't even used -- I can see how it may have been useful once for debugging, but I do quite a lot of typeck debugging and I've never really needed it. So let's just remove it, and keep around the only useful thing which is the `DefId` of the param for `var_for_def`. This is based on rust-lang#123006, which removed the special use of `TypeVariableOriginKind::OpaqueInference`, which I'm pretty sure I was the one that added. r? lcnr or re-roll to types
|
mh may need another rebase |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 6, 2024
…r=lcnr Remove `TypeVariableOriginKind` and `ConstVariableOriginKind` It's annoying to have to import `TypeVariableOriginKind` just to fill it with `MiscVariable` for almost every use. Every other usage other than `TypeParameterDefinition` wasn't even used -- I can see how it may have been useful once for debugging, but I do quite a lot of typeck debugging and I've never really needed it. So let's just remove it, and keep around the only useful thing which is the `DefId` of the param for `var_for_def`. This is based on rust-lang#123006, which removed the special use of `TypeVariableOriginKind::OpaqueInference`, which I'm pretty sure I was the one that added. r? lcnr or re-roll to types
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
compiler-errors
force-pushed
the
no-type-var-origin
branch
from
7dead92 to
a654c97
Compare
|
☔ The latest upstream changes (presumably #123762) made this pull request unmergeable. Please resolve the merge conflicts. |
compiler-errors
force-pushed
the
no-type-var-origin
branch
from
a654c97 to
98890be
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#123016 (Remove `TypeVariableOriginKind` and `ConstVariableOriginKind`) - rust-lang#123462 (Cleanup: Rename `ModSep` to `PathSep`) - rust-lang#123603 (Don't even parse an intrinsic unless the feature gate is enabled) - rust-lang#123926 (Fix pretty HIR for anon consts in diagnostics) - rust-lang#123973 (crashes: readme: add reminder to add Fixes #abcde to prs to automatically close issues.) - rust-lang#123984 (sanitizers: Add rustc_sanitizers to triagebot.toml) - rust-lang#123989 (Just use `type_dependent_def_id` to figure out what the method is for an expr) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2024
Rollup merge of rust-lang#123016 - compiler-errors:no-type-var-origin, r=lcnr Remove `TypeVariableOriginKind` and `ConstVariableOriginKind` It's annoying to have to import `TypeVariableOriginKind` just to fill it with `MiscVariable` for almost every use. Every other usage other than `TypeParameterDefinition` wasn't even used -- I can see how it may have been useful once for debugging, but I do quite a lot of typeck debugging and I've never really needed it. So let's just remove it, and keep around the only useful thing which is the `DefId` of the param for `var_for_def`. This is based on rust-lang#123006, which removed the special use of `TypeVariableOriginKind::OpaqueInference`, which I'm pretty sure I was the one that added. r? lcnr or re-roll to types
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jul 30, 2024
* Update for nix Signed-off-by: Hayashi Mikihiro <[email protected]> * Update to Rust 1.80.0 Signed-off-by: Hayashi Mikihiro <[email protected]> * Rename to BindingMode from BindingAnnotation rust-lang/rust#124047 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove TypeVariableOriginKind rust-lang/rust#123016 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove TypeVariableOrigin rust-lang/rust#124955 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove LintDiagnostic::msg rust-lang/rust#125410 Signed-off-by: Hayashi Mikihiro <[email protected]> * common.rs fmt mistake indents Signed-off-by: Hayashi Mikihiro <[email protected]> * trace_in_no_trace.rs remove mistake space Signed-off-by: Hayashi Mikihiro <[email protected]> * trace_in_no_trace.rs remove mistake head space Signed-off-by: Hayashi Mikihiro <[email protected]> --------- Signed-off-by: Hayashi Mikihiro <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Aug 7, 2024
* Update for nix Signed-off-by: Hayashi Mikihiro <[email protected]> * Update to Rust 1.80.0 Signed-off-by: Hayashi Mikihiro <[email protected]> * Rename to BindingMode from BindingAnnotation rust-lang/rust#124047 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove TypeVariableOriginKind rust-lang/rust#123016 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove TypeVariableOrigin rust-lang/rust#124955 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove LintDiagnostic::msg rust-lang/rust#125410 Signed-off-by: Hayashi Mikihiro <[email protected]> * common.rs fmt mistake indents Signed-off-by: Hayashi Mikihiro <[email protected]> * trace_in_no_trace.rs remove mistake space Signed-off-by: Hayashi Mikihiro <[email protected]> * trace_in_no_trace.rs remove mistake head space Signed-off-by: Hayashi Mikihiro <[email protected]> * Workaround for #32912 It's dirty but it worked on 2000 runs Signed-off-by: sagudev <[email protected]> --------- Signed-off-by: Hayashi Mikihiro <[email protected]> Signed-off-by: sagudev <[email protected]> Co-authored-by: Samson <[email protected]>
Gae24
pushed a commit
to Gae24/servo
that referenced
this pull request
Aug 7, 2024
* Update for nix Signed-off-by: Hayashi Mikihiro <[email protected]> * Update to Rust 1.80.0 Signed-off-by: Hayashi Mikihiro <[email protected]> * Rename to BindingMode from BindingAnnotation rust-lang/rust#124047 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove TypeVariableOriginKind rust-lang/rust#123016 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove TypeVariableOrigin rust-lang/rust#124955 Signed-off-by: Hayashi Mikihiro <[email protected]> * Remove LintDiagnostic::msg rust-lang/rust#125410 Signed-off-by: Hayashi Mikihiro <[email protected]> * common.rs fmt mistake indents Signed-off-by: Hayashi Mikihiro <[email protected]> * trace_in_no_trace.rs remove mistake space Signed-off-by: Hayashi Mikihiro <[email protected]> * trace_in_no_trace.rs remove mistake head space Signed-off-by: Hayashi Mikihiro <[email protected]> * Workaround for servo#32912 It's dirty but it worked on 2000 runs Signed-off-by: sagudev <[email protected]> --------- Signed-off-by: Hayashi Mikihiro <[email protected]> Signed-off-by: sagudev <[email protected]> Co-authored-by: Samson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's annoying to have to import
TypeVariableOriginKindjust to fill it withMiscVariablefor almost every use. Every other usage other thanTypeParameterDefinitionwasn't even used -- I can see how it may have been useful once for debugging, but I do quite a lot of typeck debugging and I've never really needed it.So let's just remove it, and keep around the only useful thing which is the
DefIdof the param forvar_for_def.This is based on #123006, which removed the special use of
TypeVariableOriginKind::OpaqueInference, which I'm pretty sure I was the one that added.r? lcnr or re-roll to types