-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn against implementing Freeze #123268
Merged
Merged
warn against implementing Freeze #123268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 31, 2024
Noratrieb
reviewed
Mar 31, 2024
RalfJung
force-pushed
the
dont-freeze
branch
2 times, most recently
from
March 31, 2024 12:28
5143221
to
9f18094
Compare
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 31, 2024
y21
reviewed
Mar 31, 2024
typo. :^) @bors r- |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 31, 2024
Ah, good catch, thanks! @bors r=Nilstrieb |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Mar 31, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
…kingjubilee Rollup of 5 pull requests Successful merges: - rust-lang#123180 (Rewrite `core-no-fp-fmt-parse` test in Rust) - rust-lang#123267 (std::thread: adding get_name haiku implementation.) - rust-lang#123268 (warn against implementing Freeze) - rust-lang#123271 (doc: describe panic conditions for SliceIndex implementations) - rust-lang#123295 (add myself to compiler review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
Rollup merge of rust-lang#123268 - RalfJung:dont-freeze, r=Nilstrieb warn against implementing Freeze As [requested](rust-lang#123184 (comment)) by `@workingjubilee`
excellent, thank you everyone! I can't wait to tell someone to stop! :^) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested by @workingjubilee