Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite core-no-fp-fmt-parse test in Rust #123180

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Rewrite core-no-fp-fmt-parse test in Rust #123180

merged 1 commit into from
Mar 31, 2024

Conversation

Oneirical
Copy link
Contributor

@Oneirical Oneirical commented Mar 29, 2024 •
edited
Loading

Claiming the simple "core-no-fp-fmt-parse" test from #121876. run_make_support was altered with arg_path written in #121918 by @abhay-51, with additional doc comment.

Preliminary GSoC contribution for the project proposal mentored by @jieyouxu.

@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2024

Some changes occurred in run-make tests.

cc @jieyouxu

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2024
@Oneirical Oneirical mentioned this pull request Mar 29, 2024
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Mar 29, 2024

The run-make-support library was changed

cc @jieyouxu

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 29, 2024
jieyouxu
jieyouxu reviewed Mar 30, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor support library API nits, otherwise looks good to me

src/tools/run-make-support/src/rustc.rs Outdated Show resolved Hide resolved
tests/run-make/core-no-fp-fmt-parse/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/core-no-fp-fmt-parse/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/core-no-fp-fmt-parse/rmake.rs Outdated Show resolved Hide resolved
@jieyouxu
Copy link
Member

Re the support library's API design: see #122460 where we experimented with a couple different variants and eventually arrived at the "weakly-typed API with helper methods variant"

@Oneirical
Copy link
Contributor Author

Re the support library's API design: see #122460 where we experimented with a couple different variants and eventually arrived at the "weakly-typed API with helper methods variant"

I see, since the original tests were quite loose, it might feel odd to implement enums like CrateType::Rlib, CrateType::Lib or CrateType::Bin. This weaker version is less verbose, but it might be worthwhile to explain the behaviour of certain specific calls in comments in future tests.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Oneirical
Rewrite core-no-fp-fmt-parse in Rust
e477488 
Rewrite core-no-fp-fmt-parse in Rust

fix: missing import

fix: tidiness check

more tidy checks

remove tidy line length ignore

new helper functions + arg_path generic

fix: remove unused import

delete arg_path, change arg_path to input
@jieyouxu
Copy link
Member

Changes look good to me, Mark will do the final review and decide if r+.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 31, 2024

📌 Commit e477488 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2024
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 31, 2024
@workingjubilee workingjubilee mentioned this pull request Mar 31, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@bors
Auto merge of rust-lang#123299 - workingjubilee:rollup-2z8amaj, r=wor…
8058136 
…kingjubilee

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123180 (Rewrite `core-no-fp-fmt-parse` test in Rust)
 - rust-lang#123267 (std::thread: adding get_name haiku implementation.)
 - rust-lang#123268 (warn against implementing Freeze)
 - rust-lang#123271 (doc: describe panic conditions for SliceIndex implementations)
 - rust-lang#123295 (add myself to compiler review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 17737bf into rust-lang:master Mar 31, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Mar 31, 2024
@bors
Copy link
Contributor

bors commented Mar 31, 2024

⌛ Testing commit e477488 with merge 8058136...

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
@rust-timer
Unrolled build for rust-lang#123180
004af8a 
Rollup merge of rust-lang#123180 - Oneirical:master, r=Mark-Simulacrum

Rewrite `core-no-fp-fmt-parse` test in Rust

Claiming the simple "core-no-fp-fmt-parse" test from rust-lang#121876. `run_make_support` was altered with `arg_path` written in rust-lang#121918 by `@abhay-51,` with additional doc comment.

Preliminary GSoC contribution for the project proposal mentored by `@jieyouxu.`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Oneirical @rustbot @rust-log-analyzer @jieyouxu @Mark-Simulacrum @bors