Rollup of 5 pull requests #119170
Merged
Rollup of 5 pull requests #119170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change how we classify item kind for DefKind::Ctor
…piler-errors Fix crash due to `CrateItem::kind()` not handling constructors Also add a method to get the instance instantiation arguments, and include that information in the instance debug.
…piler-errors Add method to get instance instantiation arguments Add a method to get the instance instantiation arguments, and include that information in the instance debug.
…truct, r=compiler-errors Give `VariantData::Struct` named fields, to clairfy `recovered`. Implements rust-lang#119121 (comment). Supersedes rust-lang#119121 This way, it's clear what the bool fields means, instead of having to find where it's generated. Changes both ast and hir. r? `@compiler-errors`
E0761: module directory has .rs suffix `rustc --explain E0761` example seems wrong.
…errors resolve: Stop feeding visibilities for import list stems Fixes rust-lang#119126
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=5 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 5ac4c8a63e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (3694a6b): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 672.809s -> 673.469s (0.10%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
CrateItem::kind()not handling constructors #119135 (Fix crash due toCrateItem::kind()not handling constructors)VariantData::Structnamed fields, to clairfyrecovered. #119145 (GiveVariantData::Structnamed fields, to clairfyrecovered.)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup