Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E0761: module directory has .rs suffix #119167

Merged
merged 1 commit into from
Dec 21, 2023
Merged

E0761: module directory has .rs suffix #119167

merged 1 commit into from
Dec 21, 2023

Conversation

alef
Copy link
Contributor

@alef alef commented Dec 20, 2023

rustc --explain E0761 example seems wrong.

@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @b-naber (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 20, 2023
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 20, 2023

📌 Commit 821fdde has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2023
@bors
Auto merge of rust-lang#119170 - matthiaskrgr:rollup-nllgdf2, r=matth…
3694a6b 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119135 (Fix crash due to `CrateItem::kind()` not handling constructors)
 - rust-lang#119141 (Add method to get instance instantiation arguments)
 - rust-lang#119145 (Give `VariantData::Struct`  named fields, to clairfy `recovered`.)
 - rust-lang#119167 (E0761: module directory has .rs suffix)
 - rust-lang#119168 (resolve: Stop feeding visibilities for import list stems)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 906606d into rust-lang:master Dec 21, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 21, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 21, 2023
@rust-timer
Unrolled build for rust-lang#119167
4872c74 
Rollup merge of rust-lang#119167 - alef:patch-1, r=compiler-errors

E0761: module directory has .rs suffix

`rustc --explain E0761` example seems wrong.
@alef alef deleted the patch-1 branch December 21, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@b-naber b-naber

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
5 participants
@alef @rustbot @compiler-errors @bors @b-naber