Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #117002

Closed
wants to merge 11 commits into from

Commits on Oct 19, 2023

  1. Configuration menu
    Copy the full SHA
    e8d4fb8 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Add stable Instance::body() and RustcInternal trait

    The `Instance::body()` returns a monomorphized body.
    
    For that, we had to implement visitor that monomorphize types and
    constants. We are also introducing the RustcInternal trait that will
    allow us to convert back from Stable to Internal.
    
    Note that this trait is not yet visible for our users as it depends on
    Tables. We should probably add a new trait that can be exposed.
    celinval committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6ed2a76 View commit details
    Browse the repository at this point in the history
  2. Remove obsolete comment

    celinval authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6e643e1 View commit details
    Browse the repository at this point in the history
  3. Typo suggestion to change bindings with leading underscore

    When encountering a binding that isn't found but has a typo suggestion
    for a binding with a leading underscore, suggest changing the binding
    definition instead of the use place.
    
    Fix rust-lang#60164.
    estebank committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b0d17f3 View commit details
    Browse the repository at this point in the history
  4. Point at assoc fn definition on type param divergence

    When the number of type parameters in the associated function of an impl
    and its trait differ, we now *always* point at the trait one, even if it
    comes from a foreign crate. When it is local, we point at the specific
    params, when it is foreign, we point at the whole associated item.
    
    Fix rust-lang#69944.
    estebank committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    939a224 View commit details
    Browse the repository at this point in the history
  5. Mention the syntax for use on mod foo; if foo doesn't exist

    Newcomers might get confused that `mod` is the only way of defining
    scopes, and that it can be used as if it were `use`.
    
    Fix rust-lang#69492.
    estebank committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8950d80 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#116911 - estebank:issue-85378, r=oli-obk

    Suggest relaxing implicit `type Assoc: Sized;` bound
    
    Fix rust-lang#85378.
    matthiaskrgr authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ce8d366 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#116961 - estebank:issue-60164, r=oli-obk

    Typo suggestion to change bindings with leading underscore
    
    When encountering a binding that isn't found but has a typo suggestion for a binding with a leading underscore, suggest changing the binding definition instead of the use place.
    
    Fix rust-lang#60164.
    matthiaskrgr authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7dd4bf2 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#116964 - celinval:smir-mono-body, r=oli-obk

    Add stable Instance::body() and RustcInternal trait
    
    The `Instance::body()` returns a monomorphized body.
    
    For that, we had to implement visitor that monomorphize types and constants. We are also introducing the RustcInternal trait that will allow us to convert back from Stable to Internal.
    
    Note that this trait is not yet visible for our users as it depends on Tables. We should probably add a new trait that can be exposed.
    
    The tests here are very simple, and I'm planning on creating more exhaustive tests in the project-mir repo. But I was hoping to get some feedback here first.
    
    r? ``@oli-obk``
    matthiaskrgr authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    581ade1 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#116992 - estebank:issue-69492, r=oli-obk

    Mention the syntax for `use` on `mod foo;` if `foo` doesn't exist
    
    Newcomers might get confused that `mod` is the only way of defining scopes, and that it can be used as if it were `use`.
    
    Fix rust-lang#69492.
    matthiaskrgr authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    9f0f4b7 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#116995 - estebank:issue-69944, r=compiler-e…

    …rrors
    
    Point at assoc fn definition on type param divergence
    
    When the number of type parameters in the associated function of an impl and its trait differ, we now *always* point at the trait one, even if it comes from a foreign crate. When it is local, we point at the specific params, when it is foreign, we point at the whole associated item.
    
    Fix rust-lang#69944.
    matthiaskrgr authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6d69a20 View commit details
    Browse the repository at this point in the history