Rollup of 5 pull requests

[matthiaskrgr]

Successful merges:

• Suggest pin!() instead of Pin::new() when appropriate #114654 (Suggest pin!() instead of Pin::new() when appropriate)
• a small wf and clause cleanup #116261 (a small wf and clause cleanup)
• Fix broken links #116282 (Fix broken links)
• Factor out common token generation in fluent_messages. #116328 (Factor out common token generation in fluent_messages.)
• non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound #116379 (non_lifetime_binders: fix ICE in lint opaque-hidden-inferred-bound)

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

[matthiaskrgr]

@bors r+ rollup=never p=5

[bors]

📌 Commit 9143370 has been approved by matthiaskrgr

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9143370 with merge 268d625...

[bors]

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 268d625 to master...

[rust-timer]

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#114654	Suggest pin!() instead of Pin::new() when appropriate	d4867d7bc37061a23bdc732c56e48169c578184a (link)
#116261	a small wf and clause cleanup	ad09210864f9ed27f2caad9888dcf1bd88084d0f (link)
#116282	Fix broken links	9c9fab70295b6beeb5b4de7fd4bc9ab1752ed8cd (link)
#116328	Factor out common token generation in fluent_messages.	d1457f935af44f361a3a0142706a0451b1714829 (link)
#116379	non_lifetime_binders: fix ICE in lint opaque-hidden-inferre…	f74dcff86b548cc18a1b3ca4976c122884b9b79d (link)

previous master: e3c631b3de

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

[rust-timer]

Finished benchmarking commit (268d625): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.8%]	4
Regressions ❌ (secondary)	0.5%	[0.3%, 1.2%]	18
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.8%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.7%	[0.7%, 0.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 620.955s -> 622.003s (0.17%)
Artifact size: 271.99 MiB -> 272.02 MiB (0.01%)

[Mark-Simulacrum]

Regressions look to be spurious/noise, marking as triaged.