Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve suggestion for self: Box<self> #111460

Merged
merged 1 commit into from
May 12, 2023
Merged

Improve suggestion for self: Box<self> #111460

merged 1 commit into from
May 12, 2023

Conversation

clubby789
Copy link
Contributor

Fixes #110642

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2023
@clubby789 clubby789 added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
clubby789
clubby789 commented May 11, 2023
View reviewed changes
compiler/rustc_middle/src/ty/util.rs
@@ -1253,7 +1253,7 @@ pub enum ExplicitSelf<'tcx> {

impl<'tcx> ExplicitSelf<'tcx> {
/// Categorizes an explicit self declaration like `self: SomeType`
/// into either `self`, `&self`, `&mut self`, `Box<self>`, or
/// into either `self`, `&self`, `&mut self`, `Box<Self>`, or
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed typo while grepping for this

@clubby789 clubby789 force-pushed the lowercase-box-self branch from ac7d432 to 3851a4b Compare May 11, 2023 12:21
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 11, 2023

📌 Commit 3851a4b has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 11, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111460 - clubby789:lowercase-box-self, r=co…
ae2f6f2 
…mpiler-errors

Improve suggestion for `self: Box<self>`

Fixes rust-lang#110642
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111460 - clubby789:lowercase-box-self, r=co…
fa96fa6 
…mpiler-errors

Improve suggestion for `self: Box<self>`

Fixes rust-lang#110642
@matthiaskrgr
Copy link
Member

@bors r-
#111479 (comment)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 11, 2023
@clubby789
Copy link
Contributor Author

I'm pretty sure the rollup failed on #111451, given the failing test name and #111482

@compiler-errors
Copy link
Member

Yeah it's that one.

@bors r+

@bors
Copy link
Contributor

bors commented May 12, 2023

📌 Commit 3851a4b has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 12, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2023
@compiler-errors compiler-errors mentioned this pull request May 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2023
@bors
Auto merge of rust-lang#111489 - compiler-errors:rollup-g3vgzss, r=co…
699a862 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106038 (use implied bounds when checking opaque types)
 - rust-lang#111366 (Make `NonUseContext::AscribeUserTy` carry `ty::Variance`)
 - rust-lang#111375 (CFI: Fix SIGILL reached via trait objects)
 - rust-lang#111439 (Fix backtrace normalization in ice-bug-report-url.rs)
 - rust-lang#111444 (Only warn single-use lifetime when the binders match.)
 - rust-lang#111459 (Update browser-ui-test version to 0.16.0)
 - rust-lang#111460 (Improve suggestion for `self: Box<self>`)

Failed merges:

 - rust-lang#110454 (Require impl Trait in associated types to appear in method signatures)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6641b49 into rust-lang:master May 12, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@compiler-errors compiler-errors

Labels
A-diagnostics Area: Messages for errors, warnings, and lints S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

Suggest a title case change when Self is mistyped as self
7 participants
@clubby789 @rustbot @rust-log-analyzer @compiler-errors @bors @matthiaskrgr @wesleywiser