Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NonUseContext::AscribeUserTy carry ty::Variance #111366

Merged
merged 1 commit into from
May 12, 2023
Merged

Make NonUseContext::AscribeUserTy carry ty::Variance #111366

merged 1 commit into from
May 12, 2023

Conversation

obeis
Copy link
Contributor

@obeis obeis commented May 8, 2023

Close #108267

@rustbot
Copy link
Collaborator

rustbot commented May 8, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 8, 2023
@compiler-errors
Copy link
Member

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned compiler-errors May 8, 2023
lcnr
lcnr reviewed May 9, 2023
View reviewed changes
compiler/rustc_borrowck/src/type_check/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/mir/visit.rs Outdated Show resolved Hide resolved
compiler/rustc_middle/src/mir/visit.rs Outdated Show resolved Hide resolved
compiler/rustc_type_ir/src/lib.rs Outdated Show resolved Hide resolved
@obeis obeis force-pushed the ascribe-user-type-variance branch from dd0e43b to 2198fae Compare May 10, 2023 06:56
@obeis obeis requested a review from lcnr May 10, 2023 07:39
@lcnr
Copy link
Contributor

lcnr commented May 11, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 11, 2023

📌 Commit 2198fae has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 11, 2023
@Dylan-DPC
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
433183d 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
@Dylan-DPC Dylan-DPC mentioned this pull request May 11, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
e1746af 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
472f2e0 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
@matthiaskrgr matthiaskrgr mentioned this pull request May 11, 2023
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
7e311dd 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
@matthiaskrgr
Rollup merge of rust-lang#111366 - obeis:ascribe-user-type-variance, …
a136959 
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
This was referenced May 11, 2023
Closed
Closed
@compiler-errors compiler-errors mentioned this pull request May 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2023
@bors
Auto merge of rust-lang#111489 - compiler-errors:rollup-g3vgzss, r=co…
699a862 
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106038 (use implied bounds when checking opaque types)
 - rust-lang#111366 (Make `NonUseContext::AscribeUserTy` carry `ty::Variance`)
 - rust-lang#111375 (CFI: Fix SIGILL reached via trait objects)
 - rust-lang#111439 (Fix backtrace normalization in ice-bug-report-url.rs)
 - rust-lang#111444 (Only warn single-use lifetime when the binders match.)
 - rust-lang#111459 (Update browser-ui-test version to 0.16.0)
 - rust-lang#111460 (Improve suggestion for `self: Box<self>`)

Failed merges:

 - rust-lang#110454 (Require impl Trait in associated types to appear in method signatures)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 41ab8e6 into rust-lang:master May 12, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 12, 2023
@obeis obeis deleted the ascribe-user-type-variance branch May 13, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjgillot cjgillot cjgillot left review comments

@lcnr lcnr Awaiting requested review from lcnr

Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

AscribeUserType statements contain variance which should be carried by NonUseContext::AscribeUserTy
6 participants
@obeis @rustbot @compiler-errors @lcnr @bors @cjgillot