Migrate rustc_passes to translatable diagnostics
#110816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
clubby789
force-pushed
the
rustc-passes-diagnostics
branch
from
e146b3c
to
cebe19f
Compare
clubby789
commented
Apr 25, 2023
clubby789
force-pushed
the
rustc-passes-diagnostics
branch
from
cebe19f
to
d518fb4
Compare
compiler-errors
approved these changes
Apr 26, 2023
|
@bors delegate+ |
|
✌️ @clubby789 can now approve this pull request |
clubby789
force-pushed
the
rustc-passes-diagnostics
branch
from
d518fb4
to
ddac20e
Compare
This comment has been minimized.
This comment has been minimized.
|
Oops - I'll fix that soon, as long as the new WET approach looks good? |
|
Looks fine to me, though I would probably just inline |
|
Either that, or make a different enum instead of using a boolean. No strong opinion. |
clubby789
force-pushed
the
rustc-passes-diagnostics
branch
from
ddac20e
to
6a41cfe
Compare
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 26, 2023
…, r=compiler-errors Migrate `rustc_passes` to translatable diagnostics cc rust-lang#100717
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 27, 2023
…, r=compiler-errors Migrate `rustc_passes` to translatable diagnostics cc rust-lang#100717
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 27, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#110426 (docs(style): add more let-else examples) - rust-lang#110804 (Remove repeated definite articles) - rust-lang#110814 (Sprinkle some `#[inline]` in `rustc_data_structures::tagged_ptr`) - rust-lang#110816 (Migrate `rustc_passes` to translatable diagnostics) - rust-lang#110864 (`IntoFuture::into_future` is no longer unstable) - rust-lang#110866 (Make `method-not-found-generic-arg-elision.rs` error message not path dependent) - rust-lang#110872 (Nicer ICE for rust-lang#67981) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #100717