Sprinkle some #[inline] in rustc_data_structures::tagged_ptr

[WaffleLapkin]

This is based on nm --demangle (rustc +a --print sysroot)/lib/librustc_driver-*.so | rg CopyTaggedPtr which shows many methods that should probably be inlined. May fix the regression in #110795.

r? @Nilstrieb

[Noratrieb]

did you do a local build with at least thin LTO to see whether they are left now?

[compiler-errors]

if it fixes a perf regression we should probably perf test this lol

@bors try @rust-timer queue

[bors]

⌛ Trying commit 021a12c with merge e1f03ce162d86cda98cd9608b46d1cd0ec69e83c...

[bors]

☀️ Try build successful - checks-actions
Build commit: e1f03ce162d86cda98cd9608b46d1cd0ec69e83c (e1f03ce162d86cda98cd9608b46d1cd0ec69e83c)

[rust-timer]

Finished benchmarking commit (e1f03ce162d86cda98cd9608b46d1cd0ec69e83c): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-2.3%	[-2.4%, -2.2%]	2
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

[WaffleLapkin]

@compiler-errors it doesn't fix an existing regression, but can (potentially) prevent it. I'm experimenting in #110795 with adding more uses of tagged pointers and that seems to regress perf, those #[inline]s might fix that. I choose a bit of a poor wording in the PR description.

[WaffleLapkin]

@Nilstrieb just checked, with this included in the config.toml:

[rust]
thin-lto-import-instr-limit = 100
lto = "thin"

The command nm --demangle (rustc +a --print sysroot)/lib/librustc_driver-*.so | rg CopyTaggedPtr founds nothing (where as before this PR it found quite a few copies of CopyTaggedPtr's function).

[Noratrieb]

well, I'm not sure whether this is worth it as you haven't benchmarked it with your other PR
on the other hand, this doesn't really hurt even if it turns out to be unnecessary
@bors r+ rollup

[bors]

📌 Commit 021a12c has been approved by Nilstrieb

It is now in the queue for this repository.