Rollup of 10 pull requests #109206

matthiaskrgr · 2023-03-16T07:57:10Z

Successful merges:

rustdoc: fix type search for Option combinators #108875 (rustdoc: fix type search for Option combinators)
error-msg: impl better suggestion for E0532 #108971 (error-msg: impl better suggestion for E0532)
rustdoc: DocFS: Replace rayon with threadpool and enable it for all targets #109139 (rustdoc: DocFS: Replace rayon with threadpool and enable it for all targets)
Assert def-kind is correct for alias types #109151 (Assert def-kind is correct for alias types)
error-msg: expand suggestion for unused_def lint #109158 (error-msg: expand suggestion for unused_def lint)
make define_opaque_types fully explicit #109166 (make define_opaque_types fully explicit)
Some cleanups in our normalization logic #109171 (Some cleanups in our normalization logic)
Unequal → Not equal #109180 (Unequal → Not equal)
rustdoc: remove std:: from primitive intra-doc link tooltips #109185 (rustdoc: remove std:: from primitive intra-doc link tooltips)
Mention UEFI target promotion in release notes for 1.67.0 #109192 (Mention UEFI target promotion in release notes for 1.67.0)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

…argets

…scaping bound vars

…r=GuillaumeGomez rustdoc: fix type search for `Option` combinators

…s, r=WaffleLapkin error-msg: impl better suggestion for `E0532` Fixes rust-lang#106862 No test as there is already a test which is nearly identical to the example in the linked issue.

…t-for-write, r=notriddle rustdoc: DocFS: Replace rayon with threadpool and enable it for all targets Fixes rust-lang#109060. Switching to `threadpool` makes it a bit simpler for us to wait for all tasks in `DocFS` directly in the `Drop` implementation. I'm also curious if making all the writes into a thread pool could improve run time for rustdoc on all other platforms than Windows as well. I'll run a perf check to see. cc ```@ehuss``` r? ```@notriddle```

…, r=WaffleLapkin Assert def-kind is correct for alias types Make sure we're not constructing alias types for the wrong def-kind, at least for debug cases 😅

…nt, r=Nilstrieb error-msg: expand suggestion for `unused_def` lint Fixes rust-lang#108885 Expands `let _ = ..` suggestion into more positions.

… r=oli-obk make `define_opaque_types` fully explicit based on the idea of rust-lang#108389. Moved `define_opaque_types` into the actual operations, e.g. `eq`, instead of `infcx.at` because normalization doesn't use `define_opaque_types` and even creates it's own `At` with a different `define_opaque_types` internally. Somewhat surprisingly, coherence actually relies on `DefineOpaqueTypes::Yes` for soundness which was revealed because I've incorrectly used `DefineOpaqueTypes::No` in `equate_impl_headers`. It feels concerning that even though this is the case, we still sometimes use `DefineOpaqueTypes::No` in coherence. I did not look into this as part of this PR as it is purely changing the structure of the code without changing behavior in any way. r? ```@oli-obk```

…ompiler-errors Some cleanups in our normalization logic Changed a match to be exhaustive and deduplicated some code. r? ```@compiler-errors``` this pulls out the uncontroversial part of rust-lang#108860

Unequal → Not equal Fixes rust-lang#109168

…tip, r=jsha rustdoc: remove `std::` from primitive intra-doc link tooltips Take the intra-doc link to the method `iter` from https://doc.rust-lang.org/nightly/std/slice/struct.Iter.html Before: `method std::slice::iter` After: `method slice::iter`

…iplett Mention UEFI target promotion in release notes for 1.67.0 The promotion happened in rust-lang#103933, but it was forgotten in the release notes for 1.67.0. See also discussion in https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/UEFI.20targets.20relnotes

matthiaskrgr · 2023-03-16T07:57:23Z

@bors r+ rollup=never p=10

bors · 2023-03-16T07:57:25Z

📌 Commit a70e138 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-03-16T11:06:06Z

⌛ Testing commit a70e138 with merge 7ac4b82...

bors · 2023-03-16T13:46:44Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7ac4b82 to master...

bors · 2023-03-16T13:46:44Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7ac4b82 to master...

rust-timer · 2023-03-16T13:46:51Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha

previous master: 7ac4b82ddd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-16T13:49:35Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#109192	30edf57136378a07e848cd3223080d604d614d64
#109185	403da0ab08c702049045672e5f19250fad5697af
#109180	1a5b3568a4654a2c30ac95c785b50215589bb2b5
#109171	6ab92b58993be83f2274da1eee3f4dd481362cc6
#109166	4e62fd36cbf756e17d66519a7f83773df8e6de07
#109158	63dfc6c80a4376046dc1168513a54cc3c04517f0
#109151	26f07c3db810975808f47fe4c3f7154875c48e3b
#109139	bf788157565660dc8aecd03314c173a137e23ee2
#108971	1970462cf0e70c20345b6557f1e832e76cbafa20
#108875	c579fb3ef79728420d5916c74e1ce4879c033e44

previous master: cd6c574af3

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-03-17T16:36:22Z

Finished benchmarking commit (7ac4b82): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.7%]	2
Regressions ❌ (secondary)	1.1%	[0.9%, 1.3%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.5%	[0.4%, 0.7%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.8%	[0.7%, 4.9%]	2
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-1.5%	[-3.3%, -0.6%]	4
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.0%	[-3.3%, 4.9%]	6

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.4%, 0.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-3.4%	[-3.4%, -3.4%]	1
All ❌✅ (primary)	-0.6%	[-2.9%, 0.6%]	3

lqd · 2023-03-17T16:41:54Z

tt-muncher is being noisy, and the other 2 primary regressions are small rustdoc regressions that are probably fine ?

pnkfelix · 2023-03-21T16:10:49Z

Visiting for perf-triage. I agree with @lqd 's assessment.

@rustbot label: +perf-regression-triaged

notriddle and others added 24 commits March 7, 2023 11:20

rustdoc: fix type search index for fn<T>() -> &T where T: Trait

a6446c5

rustdoc: fix type search when more than one where clause applies

44813e0

rustdoc: DocFS: Replace rayon with threadpool and enable it for all t…

50f7520

…argets

Assert def-kind is correct for alias types

e482701

Don't make projection tys out of anon consts

cf6424e

error-msg: impl better suggestion for E0532

bd17322

error-msg: expand suggestion for unused lint

35103fe

Exhaustively match over all alias kinds

d3d537b

Deduplicate logic between projection normalization with and without e…

d87fbb9

…scaping bound vars

always make define_opaque_types explicit

d2b7604

Update docsfs module documentation

e667872

unequal → not equal

e5a5b90

rustdoc: remove std:: from primitive intra-doc link tooltips

683c12c

Mention UEFI target promotion in release notes for 1.67.0

3f250a9

Rollup merge of rust-lang#108875 - notriddle:notriddle/return-trait, …

aa881f1

…r=GuillaumeGomez rustdoc: fix type search for `Option` combinators

Rollup merge of rust-lang#108971 - Ezrashaw:E0532-better-binding-name…

1385a32

…s, r=WaffleLapkin error-msg: impl better suggestion for `E0532` Fixes rust-lang#106862 No test as there is already a test which is nearly identical to the example in the linked issue.

Rollup merge of rust-lang#109151 - compiler-errors:debug-assert-alias…

9d5d447

…, r=WaffleLapkin Assert def-kind is correct for alias types Make sure we're not constructing alias types for the wrong def-kind, at least for debug cases 😅

Rollup merge of rust-lang#109158 - Ezrashaw:expand-sugg-for-unused-li…

36b8237

…nt, r=Nilstrieb error-msg: expand suggestion for `unused_def` lint Fixes rust-lang#108885 Expands `let _ = ..` suggestion into more positions.

Rollup merge of rust-lang#109171 - oli-obk:normalization_cleanup, r=c…

113e815

…ompiler-errors Some cleanups in our normalization logic Changed a match to be exhaustive and deduplicated some code. r? ```@compiler-errors``` this pulls out the uncontroversial part of rust-lang#108860

Rollup merge of rust-lang#109180 - gimbles:master, r=compiler-errors

7696248

Unequal → Not equal Fixes rust-lang#109168

rustbot added the rollup A PR which is a rollup label Mar 16, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2023

bors added merged-by-bors This PR was explicitly merged by bors. labels Mar 16, 2023

bors merged commit 7ac4b82 into rust-lang:master Mar 16, 2023

rustbot added this to the 1.70.0 milestone Mar 16, 2023

rustbot added the perf-regression Performance regression. label Mar 17, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 21, 2023

gurry mentioned this pull request Dec 21, 2023

arithmetic_overflow lint not triggered for overflowing shifts in promoteds #117949

Closed

matthiaskrgr deleted the rollup-oev8ax6 branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 10 pull requests #109206

Rollup of 10 pull requests #109206

matthiaskrgr commented Mar 16, 2023

matthiaskrgr commented Mar 16, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

rust-timer commented Mar 16, 2023

rust-timer commented Mar 16, 2023

rust-timer commented Mar 17, 2023

lqd commented Mar 17, 2023

pnkfelix commented Mar 21, 2023

Rollup of 10 pull requests #109206

Rollup of 10 pull requests #109206

Conversation

matthiaskrgr commented Mar 16, 2023

matthiaskrgr commented Mar 16, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

rust-timer commented Mar 16, 2023

rust-timer commented Mar 16, 2023

rust-timer commented Mar 17, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

lqd commented Mar 17, 2023

pnkfelix commented Mar 21, 2023