Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2 #103933

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2 #103933

merged 1 commit into from
Nov 9, 2022

Conversation

nicholasbishop
Copy link
Contributor

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2022

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 3, 2022
@JohnTitor
Copy link
Member

I'm going to r+ as the MCP has been completed and this follows the same way as #95705.
just in case cc @oli-obk as you seconded the MCP

@bors r+

@bors
Copy link
Contributor

bors commented Nov 4, 2022

📌 Commit 006e05aa1c3e418567c68a76993c809d5ca7eef2 has been approved by JohnTitor

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2022
dvdhrm
dvdhrm approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@dvdhrm dvdhrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good!

src/doc/rustc/src/platform-support/unknown-uefi.md Outdated
+nightly \
xbuild \
--target x86_64-unknown-uefi
```text
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the change from sh to text intentional? The comments should work fine in sh, shouldn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed. (I had copy-pasted that from https://github.com/rust-lang/rust/pull/95705/files#diff-7a14c39a7e2dc831476df3687623b15a8ac53450b9fe34769b1fba1fe4d16ef9R54)

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 4, 2022

📌 Commit 971a146 has been approved by JohnTitor

It is now in the queue for this repository.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 7, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103933 - nicholasbishop:bishop-uefi-tier-2,…
bc3c840 
… r=JohnTitor

Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2

MCP: rust-lang/compiler-team#555

CC `@dvdhrm`
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 7, 2022
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 7, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103933 - nicholasbishop:bishop-uefi-tier-2,…
e451151 
… r=JohnTitor

Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2

MCP: rust-lang/compiler-team#555

CC ``@dvdhrm``
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 7, 2022
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 8, 2022
@GuillaumeGomez
Rollup merge of rust-lang#103933 - nicholasbishop:bishop-uefi-tier-2,…
1b420b0 
… r=JohnTitor

Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2

MCP: rust-lang/compiler-team#555

CC ```@dvdhrm```
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 8, 2022
Closed
@GuillaumeGomez
Copy link
Member

I think this is the one which failed in #104143 (comment). Please don't hesitate to re-r+ if my guess was wrong.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 8, 2022
@nicholasbishop
Copy link
Contributor Author

It looks like the job that failed was dist-aarch64-msvc, with bad arguments passed to armasm. This PR shouldn't have affected aarch64-msvc. Maybe the cc upgrade PR was the problem?

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 8, 2022
@GuillaumeGomez
Copy link
Member

I guess we'll know soon enough. I made another rollup with the cc update there: #104152

@nicholasbishop
Copy link
Contributor Author

The new rollup without this PR failed, looks like it's the same aarch64-msvc error as before. So I think this PR can be re-approved.

@GuillaumeGomez
Copy link
Member

Absolutely!

@bors r=JohnTitor

@bors
Copy link
Contributor

bors commented Nov 8, 2022

📌 Commit 971a146 has been approved by JohnTitor

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Nov 9, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 9, 2022
@bors
Auto merge of rust-lang#104192 - Dylan-DPC:rollup-jjo1o80, r=Dylan-DPC
c716587 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#103570 (Stabilize integer logarithms)
 - rust-lang#103694 (Add documentation examples for `pointer::mask`)
 - rust-lang#103919 (Unescaping cleanups)
 - rust-lang#103933 (Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2)
 - rust-lang#103952 (Don't intra linkcheck reference)
 - rust-lang#104111 (rustdoc: Add mutable to the description)
 - rust-lang#104125 (Const Compare for Tuples)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2313d32 into rust-lang:master Nov 9, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 9, 2022
@nicholasbishop nicholasbishop deleted the bishop-uefi-tier-2 branch November 9, 2022 20:27
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@Dylan-DPC
Rollup merge of rust-lang#103933 - nicholasbishop:bishop-uefi-tier-2,…
f06b6b6 
… r=JohnTitor

Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2

MCP: rust-lang/compiler-team#555

CC `@dvdhrm`
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
@bors
Auto merge of rust-lang#104192 - Dylan-DPC:rollup-jjo1o80, r=Dylan-DPC
1bf321a 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#103570 (Stabilize integer logarithms)
 - rust-lang#103694 (Add documentation examples for `pointer::mask`)
 - rust-lang#103919 (Unescaping cleanups)
 - rust-lang#103933 (Promote {aarch64,i686,x86_64}-unknown-uefi to Tier 2)
 - rust-lang#103952 (Don't intra linkcheck reference)
 - rust-lang#104111 (rustdoc: Add mutable to the description)
 - rust-lang#104125 (Const Compare for Tuples)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee added the O-UEFI UEFI label Feb 27, 2023
@lukas-code lukas-code mentioned this pull request Mar 15, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 16, 2023
@matthiaskrgr
Rollup merge of rust-lang#109192 - lukas-code:uefi-relnotes, r=joshtr…
1326ced 
…iplett

Mention UEFI target promotion in release notes for 1.67.0

The promotion happened in rust-lang#103933, but it was forgotten in the release notes for 1.67.0.

See also discussion in https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/UEFI.20targets.20relnotes
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 16, 2023
@matthiaskrgr
Rollup merge of rust-lang#109192 - lukas-code:uefi-relnotes, r=joshtr…
a70e138 
…iplett

Mention UEFI target promotion in release notes for 1.67.0

The promotion happened in rust-lang#103933, but it was forgotten in the release notes for 1.67.0.

See also discussion in https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/UEFI.20targets.20relnotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@dvdhrm dvdhrm dvdhrm approved these changes

Assignees

@JohnTitor JohnTitor

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-UEFI UEFI S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.67.0
Development

Successfully merging this pull request may close these issues.
7 participants
@nicholasbishop @rustbot @JohnTitor @bors @GuillaumeGomez @dvdhrm @workingjubilee