-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Erase regions before doing uninhabited check in borrowck #107532
Erase regions before doing uninhabited check in borrowck #107532
Conversation
r? @jackh726 (rustbot has picked a reviewer for you, use r? to override) |
A little bit more background here, on the problem and the fix, would be helpful. I can understand why it's okay to do this, but not why it's needed. |
Not sure exactly whether you're looking for:
Does that make sense? I can go into more detail if you'd like. |
Right, I'm more curious why we have unresolved inference variables? r=me, but a comment would be nice |
Oh, it's unresolved region vids, cause it's MIR borrowck and we haven't yet done the region solving yet 😆 I'll leave a comment |
Gonna drop bbf3383 from this, since that's blocked on some rustdoc + const eval bug :/ I'm still gonna land the real fix for the issue, though. |
24a97e2
to
2c23c7f
Compare
@bors r=jackh726 |
🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened. |
…ninhabited, r=jackh726 Erase regions before doing uninhabited check in borrowck ~Also, fingerprint query keys/values when debug assertions are enabled. This should make it easier to check for issues like this without `-Cincremental`, and make UI tests a bit cleaner.~ edit: moving that to a separate PR Fixes rust-lang#107505
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106919 (Recover `_` as `..` in field pattern) - rust-lang#107493 (Improve diagnostic for missing space in range pattern) - rust-lang#107515 (Improve pretty-printing of `HirIdValidator` errors) - rust-lang#107524 (Remove both StorageLive and StorageDead in CopyProp.) - rust-lang#107532 (Erase regions before doing uninhabited check in borrowck) - rust-lang#107559 (Rename `rust_2015` → `is_rust_2015`) - rust-lang#107577 (Reinstate the `hir-stats.rs` tests on stage 1.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Also, fingerprint query keys/values when debug assertions are enabled. This should make it easier to check for issues like this withoutedit: moving that to a separate PR-Cincremental
, and make UI tests a bit cleaner.Fixes #107505