Improve diagnostic for missing space in range pattern #107493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-translation
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
tests/ui/half-open-range-patterns/half-open-range-pats-inclusive-match-arrow.stderr
Outdated
Show resolved
Hide resolved
clubby789
force-pushed
the
range-fat-arrow-followup
branch
2 times, most recently
from
692fefe to
63ce616
Compare
estebank
reviewed
Jan 31, 2023
estebank
approved these changes
Jan 31, 2023
clubby789
force-pushed
the
range-fat-arrow-followup
branch
from
63ce616 to
f1cb13e
Compare
bors
added
S-waiting-on-bors
|
⌛ Testing commit f1cb13e with merge f01413d403e44dd9a3ee35752272555ef6d1ffd6... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry CI was broken |
bors
added
S-waiting-on-bors
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Feb 2, 2023
…, r=estebank Improve diagnostic for missing space in range pattern Improves the diagnostic in rust-lang#107425 by turning it into a note explaining the parsing issue. r? `@compiler-errors`
|
☔ The latest upstream changes (presumably #105670) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-author
clubby789
force-pushed
the
range-fat-arrow-followup
branch
from
f1cb13e to
4ab75de
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 2, 2023
…, r=estebank Improve diagnostic for missing space in range pattern Improves the diagnostic in rust-lang#107425 by turning it into a note explaining the parsing issue. r? `@compiler-errors`
This comment has been minimized.
This comment has been minimized.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 2, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#106919 (Recover `_` as `..` in field pattern) - rust-lang#107493 (Improve diagnostic for missing space in range pattern) - rust-lang#107515 (Improve pretty-printing of `HirIdValidator` errors) - rust-lang#107524 (Remove both StorageLive and StorageDead in CopyProp.) - rust-lang#107532 (Erase regions before doing uninhabited check in borrowck) - rust-lang#107559 (Rename `rust_2015` → `is_rust_2015`) - rust-lang#107577 (Reinstate the `hir-stats.rs` tests on stage 1.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the diagnostic in #107425 by turning it into a note explaining the parsing issue.
r? @compiler-errors