Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: remove no-op CSS .source pre { overflow: auto } #105619

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Dec 12, 2022

Since source pages use the example-wrap wrapper, this rule became redundant because there is already an overflow-x: auto rule.

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

r? @jsha

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 12, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2022

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Since source pages use the `example-wrap` wrapper, this rule became
redundant because there is already an `overflow-x: auto` rule.
@notriddle notriddle force-pushed the notriddle/source-pre-overflow branch from 3f7b18e to bfc50d0 Compare December 12, 2022 17:02
@GuillaumeGomez
Copy link
Member

Thanks!

r=me once CI pass

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Dec 12, 2022

📌 Commit bfc50d0 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2022
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#104405 (1.66.0 release notes)
 - rust-lang#105561 (Normalize receiver substs and erase the regions)
 - rust-lang#105593 (Fix typo in comment: length_limit)
 - rust-lang#105597 (Correct typos in `core::sync::Exclusive::get_{pin_mut, mut}`)
 - rust-lang#105614 (delete mentions of type ascription from lint descriptions)
 - rust-lang#105615 (Fixup method doc that mentions removed param)
 - rust-lang#105616 (Add a "the" to proc_macro documentation)
 - rust-lang#105619 (rustdoc: remove no-op CSS `.source pre { overflow: auto }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ab29c04 into rust-lang:master Dec 13, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 13, 2022
@notriddle notriddle deleted the notriddle/source-pre-overflow branch December 13, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants