Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure query backtraces work for DefIds created after ast lowering #105133

Merged
merged 2 commits into from
Dec 3, 2022
Merged

Ensure query backtraces work for DefIds created after ast lowering #105133

merged 2 commits into from
Dec 3, 2022

Commits on Dec 1, 2022

  1. Don't allow feeding a query cache entry twice

    @oli-obk
    oli-obk committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    a0bdb4b View commit details
    Browse the repository at this point in the history

  2. Fill in def_span when creating def ids. 

    This makes sure that ICEing because of def ids created outside of ast lowering will be able to produce a query backtrace and not cause a double panic because of trying to call the  `def_span` query
    @oli-obk
    oli-obk committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    ab75d77 View commit details
    Browse the repository at this point in the history