Rollup of 6 pull requests #104340
Closed
Rollup of 6 pull requests #104340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows people to treat them like real links, such as right-click to copy URL, and makes the line numbers in a scraped example work at all, when before this commit was added, they had the clickable pointer cursor but did not actually do anything when clicked.
Add lots of comments to this test and enable parts of the test that were added but never ran. Signed-off-by: David Wood <[email protected]>
`CompiledModule` should not think a DWARF object was emitted when a bitcode-only compilation has happened, this can confuse archive file creation (which expects to create an archive containing non-existent dwo files). Signed-off-by: David Wood <[email protected]>
It's a link. This is the default CSS for it.
This makes it a lot easier to understand what commands will be run without having to parse the `-vv` output, which isn't meant to be user facing.
These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components.
Don't set `is_preview` for clippy and rustfmt These have been shipped on stable for many years now and it would be very disruptive to ever remove them. Remove the `-preview` suffix from their dist components. Based on rust-lang#102565.
…r=GuillaumeGomez rustdoc: change `.src-line-numbers > span` to `.src-line-numbers > a` Example: https://notriddle.com/notriddle-rustdoc-demos/line-anchors/test_dingus/fn.test.html This allows people to treat them like real links, such as right-click to copy URL, and makes the line numbers in a scraped example work at all, when before this commit was added, they had the clickable pointer cursor but did not actually do anything when clicked.
…mulacrum Print "Checking/Building ..." message even when --dry-run is passed Print "Checking/Building ..." message even when --dry-run is passed This makes it a lot easier to understand what commands will be run without having to parse the `-vv` output, which isn't meant to be user facing. I also want to change these messages at some point (rust-lang#102003) and this change will make it easier to paste a before/after comparison without having to actually build a stage 2 compiler.
…elwoerister llvm: dwo only emitted when object code emitted Fixes rust-lang#103932. `CompiledModule` should not think a DWARF object was emitted when a bitcode-only compilation has happened, this can confuse archive file creation (which expects to create an archive containing non-existent dwo files). r? `````@michaelwoerister`````
…it-v2, r=GuillaumeGomez rustdoc: use consistent "popover" styling for notable traits Follow-up to rust-lang#104129 Fixes rust-lang#104313. Preview: https://notriddle.com/notriddle-rustdoc-demos/js-notable-trait-v2/std/iter/trait.Iterator.html#method.step_by ## Before   ## After  
…ckground, r=GuillaumeGomez
rustdoc: remove no-op CSS `.scrape-help { background: transparent }`
It's a link. This is the default CSS for it.
rustbot
added
T-bootstrap
|
@bors p=5 rollup=never r+ |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 8cbb52d with merge 3697d24d2ca90e4eeb6ac656b6a75f13dadd9637... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_previewfor clippy and rustfmt #103648 (Don't setis_previewfor clippy and rustfmt).src-line-numbers > spanto.src-line-numbers > a#103650 (rustdoc: change.src-line-numbers > spanto.src-line-numbers > a).scrape-help { background: transparent }#104323 (rustdoc: remove no-op CSS.scrape-help { background: transparent })Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup