rustdoc: use consistent "popover" styling for notable traits #104177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @CraftSpider (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
notriddle
force-pushed
the
notriddle/js-notable-trait-v2
branch
from
f019070
to
156487e
Compare
|
☔ The latest upstream changes (presumably #104293) made this pull request unmergeable. Please resolve the merge conflicts. |
notriddle
force-pushed
the
notriddle/js-notable-trait-v2
branch
2 times, most recently
from
cd0d5e4
to
fce7458
Compare
notriddle
force-pushed
the
notriddle/js-notable-trait-v2
branch
from
fce7458
to
79b6112
Compare
|
Some changes occurred in HTML/CSS themes. A change occurred in the Ayu theme. cc @Cldfire Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
GuillaumeGomez
approved these changes
Nov 12, 2022
|
This is awesome! Looks so nice now. Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2022
…ource-link, r=notriddle Fix non clickable source link Fixes rust-lang#104313. It was also fixed in rust-lang#104177. If rust-lang#104177 is merged first, I'll simply remove the first commit to keep the test. r? `@notriddle`
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2022
…ource-link, r=notriddle Fix non clickable source link Fixes rust-lang#104313. It was also fixed in rust-lang#104177. If rust-lang#104177 is merged first, I'll simply remove the first commit to keep the test. r? ``@notriddle``
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Nov 12, 2022
…it-v2, r=GuillaumeGomez rustdoc: use consistent "popover" styling for notable traits Follow-up to rust-lang#104129 Fixes rust-lang#104313. Preview: https://notriddle.com/notriddle-rustdoc-demos/js-notable-trait-v2/std/iter/trait.Iterator.html#method.step_by ## Before   ## After  
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2022
Rollup of 5 pull requests Successful merges: - rust-lang#103650 (rustdoc: change `.src-line-numbers > span` to `.src-line-numbers > a`) - rust-lang#104177 (rustdoc: use consistent "popover" styling for notable traits) - rust-lang#104318 (Move tests) - rust-lang#104323 (rustdoc: remove no-op CSS `.scrape-help { background: transparent }`) - rust-lang#104345 (Fix up a Fluent message) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #104129
Fixes #104313.
Preview: https://notriddle.com/notriddle-rustdoc-demos/js-notable-trait-v2/std/iter/trait.Iterator.html#method.step_by
Before
After