-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: remove unused CSS .out-of-band { font-weight: normal }
#103370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Oct 21, 2022
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @CraftSpider (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 21, 2022
notriddle
force-pushed
the
notriddle/out-of-band
branch
from
October 21, 2022 21:12
62f8869
to
9e75385
Compare
rustbot
added
the
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
label
Oct 21, 2022
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
notriddle
force-pushed
the
notriddle/out-of-band
branch
from
October 21, 2022 21:13
9e75385
to
033becc
Compare
This CSS was added in 083c395 to normalize the appearance of out-of-band elements that were nested directly below headers. Now, the only use of `out-of-band` is in the main page header, and it is nested below a wrapper, not the `<h1>` itself.
notriddle
force-pushed
the
notriddle/out-of-band
branch
from
October 21, 2022 21:13
033becc
to
1adb4c3
Compare
notriddle
removed
the
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
label
Oct 21, 2022
GuillaumeGomez
approved these changes
Oct 21, 2022
Thanks! r=me once CI pass. |
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 21, 2022
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 21, 2022
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Oct 21, 2022
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 21, 2022
…=GuillaumeGomez rustdoc: remove unused CSS `.out-of-band { font-weight: normal }` This CSS was added in 083c395 to normalize the appearance of out-of-band elements that were nested directly below headers. Now, the only use of `out-of-band` is in the main page header, and it is nested below a wrapper, not the `<h1>` itself.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 21, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#102635 (make `order_dependent_trait_objects` show up in future-breakage reports) - rust-lang#103335 (Replaced wrong test with the correct mcve) - rust-lang#103339 (Fix some typos) - rust-lang#103340 (WinConsole::new is not actually fallible) - rust-lang#103341 (Add test for issue 97607) - rust-lang#103351 (Require Drop impls to have the same constness on its bounds as the bounds on the struct have) - rust-lang#103359 (Remove incorrect comment in `Vec::drain`) - rust-lang#103364 (rustdoc: clean up rustdoc-toggle CSS) - rust-lang#103370 (rustdoc: remove unused CSS `.out-of-band { font-weight: normal }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CSS was added in 083c395 to normalize the appearance of out-of-band elements that were nested directly below headers.
Now, the only use of
out-of-band
is in the main page header, and it is nested below a wrapper, not the<h1>
itself.