Remove incorrect comment in Vec::drain
#103359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Oct 21, 2022
…cottmcm Remove incorrect comment in `Vec::drain` r? `@scottmcm` Turns out this comment wasn't correct for 6 years, since rust-lang#34951, which switched from using `slice::IterMut` into using `slice::Iter`.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 21, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#102635 (make `order_dependent_trait_objects` show up in future-breakage reports) - rust-lang#103335 (Replaced wrong test with the correct mcve) - rust-lang#103339 (Fix some typos) - rust-lang#103340 (WinConsole::new is not actually fallible) - rust-lang#103341 (Add test for issue 97607) - rust-lang#103351 (Require Drop impls to have the same constness on its bounds as the bounds on the struct have) - rust-lang#103359 (Remove incorrect comment in `Vec::drain`) - rust-lang#103364 (rustdoc: clean up rustdoc-toggle CSS) - rust-lang#103370 (rustdoc: remove unused CSS `.out-of-band { font-weight: normal }`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @scottmcm
Turns out this comment wasn't correct for 6 years, since #34951, which switched from using
slice::IterMutinto usingslice::Iter.