Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve example of Iterator::reduce #102435

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Improve example of Iterator::reduce #102435

merged 1 commit into from
Sep 29, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #81819.

I took your example @bstrie from #81819 and applied it here.

r? @thomcc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 28, 2022
@thomcc
Copy link
Member

thomcc commented Sep 28, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 28, 2022

📌 Commit c61577949291b3b5bfd51ab170e0dbb7f16b96d8 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2022
@vacuus
Copy link
Contributor

vacuus commented Sep 28, 2022

(Apparently I have nothing better to do than to browse PRs here!)
The comment talking about fold should say "equivalent to" rather than "equivalent than".

@GuillaumeGomez
Copy link
Member Author

Thanks @vacuus !

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2022
@GuillaumeGomez GuillaumeGomez force-pushed the improve-iterator-reduce-example branch from c615779 to 49b25d3 Compare September 28, 2022 22:45
@GuillaumeGomez
Copy link
Member Author

@bors r=thomcc,vacuus rollup

@bors
Copy link
Contributor

bors commented Sep 29, 2022

📌 Commit 49b25d3 has been approved by thomcc,vacuus

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 29, 2022
@Dylan-DPC Dylan-DPC mentioned this pull request Sep 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2022
@bors
Auto merge of rust-lang#102471 - Dylan-DPC:rollup-ij3okjt, r=Dylan-DPC
65445a5 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#102336 (Fix associated type bindings with anon const in GAT position)
 - rust-lang#102342 (Add negation methods for signed non-zero integers.)
 - rust-lang#102385 (Don't export `__heap_base` and `__data_end` on wasm32-wasi.)
 - rust-lang#102435 (Improve example of Iterator::reduce)
 - rust-lang#102436 (rustdoc: clean up "normalize.css 8" input override CSS)
 - rust-lang#102452 (fix minor ungrammatical sentence)
 - rust-lang#102455 (Use let-chaining in `WhileTrue::check_expr`.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b6d1c15 into rust-lang:master Sep 29, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 29, 2022
@GuillaumeGomez GuillaumeGomez deleted the improve-iterator-reduce-example branch September 29, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.

[ER] Iterator::reduce docs example code
6 participants
@GuillaumeGomez @rustbot @thomcc @bors @vacuus @rust-highfive