Add negation methods for signed non-zero integers. #102342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-libs
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. Please see the contribution instructions for more information. |
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
rust-highfive
added
the
S-waiting-on-review
rustbot
added
the
T-libs-api
rustbot
removed
the
T-libs
jmillikin
force-pushed
the
nonzero-negation
branch
from
a955916 to
259bbfb
Compare
scottmcm
reviewed
Sep 28, 2022
scottmcm
reviewed
Sep 28, 2022
scottmcm
added
S-waiting-on-author
4 tasks
|
@bors r+ |
bors
added
S-waiting-on-bors
notriddle
added a commit
to notriddle/rust
that referenced
this pull request
Sep 29, 2022
…tmcm
Add negation methods for signed non-zero integers.
Performing negation with defined wrapping semantics (such as `wrapping_neg()`) on a non-zero integer currently requires unpacking to a primitive and re-wrapping. Since negation of non-zero signed integers always produces a non-zero result, it is safe to implement the various `*_neg()` methods for `NonZeroI{N}`.
I'm not sure what to do about the `#[unstable(..., issue = "none")]` here -- should I file a tracking issue, or is that handled by the Rust dev team?
ACP: rust-lang/libs-team#105
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 29, 2022
Rollup of 7 pull requests Successful merges: - rust-lang#102336 (Fix associated type bindings with anon const in GAT position) - rust-lang#102342 (Add negation methods for signed non-zero integers.) - rust-lang#102385 (Don't export `__heap_base` and `__data_end` on wasm32-wasi.) - rust-lang#102435 (Improve example of Iterator::reduce) - rust-lang#102436 (rustdoc: clean up "normalize.css 8" input override CSS) - rust-lang#102452 (fix minor ungrammatical sentence) - rust-lang#102455 (Use let-chaining in `WhileTrue::check_expr`.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing negation with defined wrapping semantics (such as
wrapping_neg()) on a non-zero integer currently requires unpacking to a primitive and re-wrapping. Since negation of non-zero signed integers always produces a non-zero result, it is safe to implement the various*_neg()methods forNonZeroI{N}.I'm not sure what to do about the
#[unstable(..., issue = "none")]here -- should I file a tracking issue, or is that handled by the Rust dev team?ACP: rust-lang/libs-team#105