-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: remove unused CSS #main-content > table td
#101507
Merged
bors
merged 1 commit into
rust-lang:master
from
notriddle:notriddle/main-content-table-td
Sep 7, 2022
Merged
rustdoc: remove unused CSS #main-content > table td
#101507
bors
merged 1 commit into
rust-lang:master
from
notriddle:notriddle/main-content-table-td
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
label
Sep 6, 2022
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha |
r? @jsha (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Sep 6, 2022
GuillaumeGomez
approved these changes
Sep 7, 2022
Thanks! @bors r+ rollup |
📌 Commit c33b741d19a91620f1a0c21a4cdfaba99933c7ef has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Sep 7, 2022
notriddle
changed the title
rustdoc: remove unsued CSS
rustdoc: remove unused CSS Sep 7, 2022
#main-content > table td
#main-content > table td
notriddle
force-pushed
the
notriddle/main-content-table-td
branch
from
September 7, 2022 16:52
c33b741
to
43681db
Compare
This rule was added in 4e2c59a to benefit the module items table. However, the module items table stopped using table tags when 6020c79 switched us over to grid layout. You can see when this one used to be triggered by visiting <https://doc.rust-lang.org/1.54.0/alloc/slice/index.html#structs-1> in a very narrow window, but it doesn't any more, because the module table is now rendered using `<div>` tags.
@bors r=GuillaumeGomez rollup s/unsued/unused/ with no actual code changes |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 7, 2022
…iaskrgr Rollup of 14 pull requests Successful merges: - rust-lang#101343 (Add -api-level to pm command) - rust-lang#101416 (stdio: Document no support for writing to non-blocking stdio/stderr) - rust-lang#101435 (Remove unnecessary `EMIT_MIR_FOR_EACH_BITWIDTH`) - rust-lang#101493 (Pass ImplTraitContext as &mut to avoid the need of ImplTraitContext::reborrow) - rust-lang#101502 (Do not suggest a semicolon for a macro without `!`) - rust-lang#101503 (Add debug calls) - rust-lang#101506 (rustdoc: remove unused CSS `#main-content > .since`) - rust-lang#101507 (rustdoc: remove unused CSS `#main-content > table td`) - rust-lang#101521 (Rustdoc-Json: More accurate struct type.) - rust-lang#101525 (Fix typo in pass_manager.rs) - rust-lang#101534 (rustdoc: remove unused mobile CSS `.rustdoc { flex-direction }`) - rust-lang#101535 (Fix error printing mistake in tidy) - rust-lang#101536 (Add documentation for Attr::is_doc_comment) - rust-lang#101538 (rustdoc: remove unused CSS `.content .methods > div`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule was added in 4e2c59a to benefit the module items table. However, the module items table stopped using table tags when 6020c79 switched us over to grid layout.
You can see when this one used to be triggered by visiting https://doc.rust-lang.org/1.54.0/alloc/slice/index.html#structs-1 in a very narrow window, but it doesn't any more, because the module table is now rendered using
<div>
tags.