Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 13 pull requests #100426

Merged
merged 36 commits into from
Aug 12, 2022
Merged

Rollup of 13 pull requests #100426

merged 36 commits into from
Aug 12, 2022

Commits on Jul 20, 2022

  1. Configuration menu
    Copy the full SHA
    5848c27 View commit details
    Browse the repository at this point in the history
  2. fix typo

    Co-authored-by: Marco Colombo <[email protected]>
    RalfJung and mcol authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    2d1c683 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Configuration menu
    Copy the full SHA
    a61c841 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. Configuration menu
    Copy the full SHA
    725da87 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Add x.sh and x.ps1 shell scripts

    This is a more ambitious version of rust-lang#98716.
    It still changes the shebang back to python3, for compatibility with non-Unix systems,
    but also adds alternative entrypoints for systems without `python3` installed.
    
    These scripts will be necessary for the rust entrypoint (rust-lang#94829), so I see
    little downside in adding them early.
    jyn514 committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    775c3c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2022

  1. Move JSON tests into a directory.

    To get around the "following path contains more than 968 entries, you
    should move the test to some relevant subdirectory" tidy error.
    nnethercote committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c32969d View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. rustdoc: simplify highlight.rs

    Split render_with_highlighting, which took many optional parameters, into three
    functions for specific purposes, which each take a smaller number of mostly
    required parameters.
    
    Remove some plumbing to pass through an "edition" parameter, which was used
    solely to avoid highlighting some 2021 Edition keywords in non-2021 code.
    jsha committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    5938fd7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be5672e View commit details
    Browse the repository at this point in the history
  3. Improve crate selection on rustdoc search results page

    Resolves all of issue rust-lang#93240
    
    Reproduces a similar change as rust-lang#99086, but with improvements
    
    In particular, this PR inlcludes:
    * redesigning the crate-search selector so the background color matches its surroundings
    * decrease the font of the dropdown menu to a reaonable size
    * add a hover effect
    * make the color of the arrow theme-dependent, using a surrounding div, with :after pseudo-element
      that can then be transformed using CSS filters to approximate the desired color
    * fix the text "in" to match the title font
    * remove the "for xyz" in the "Results for xyz in [All crates]" title when
      searching for search term "xyz"; you can already see what you're searching for
      as it's typed in the search bar!
    * in line with rust-lang#99086, handle super-long crate names appropriately without a long <select>
      element escaping the screen area; the improvement is that we also keep the title
      within a single line now; uses some flex layout shenanigans...
    * the margins / paddings are adjusted so the selected label of the <select> fits within
      the rest of that title nicely; also some inconsistency in the way that Firefox renders
      a <select> with "appearance: none" (roughly 4px more padding left and right of the text
      than e.g. Chrome) is worked around, and it now produces a result that looks (essentially)
      identical to Chrome
    * the color of the help menu and settings menu border in light theme is made to match with
      the color of the corresponding buttons, like they do (match) in the ayu theme
    * the casing of "All crates" changes to "all crates"
    * the new tests from rust-lang#99086 are temporarily disabled, until they can be adapted later
    steffahn authored and GuillaumeGomez committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    16bcc18 View commit details
    Browse the repository at this point in the history
  4. Two small improvements:

    Fix oversight duplicate property left in CSS (dark theme).
    
    Improve wording in comment that mentions `appearance: none`
    steffahn authored and GuillaumeGomez committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    e957480 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    107e039 View commit details
    Browse the repository at this point in the history
  6. Update GUI test

    GuillaumeGomez committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    ea05be2 View commit details
    Browse the repository at this point in the history
  7. rustdoc: make item-infos dimmer on dark theme rust-lang#93896

    Previously the item-info background colors were too bright for a dark
    theme, making a bright rectangle that draws the attention.
    jsha committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    20cc5f9 View commit details
    Browse the repository at this point in the history
  8. add crt-static for android

    Bryanskiy committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    874ee5b View commit details
    Browse the repository at this point in the history
  9. grammar

    Co-authored-by: Frank Steffahn <[email protected]>
    RalfJung and steffahn authored Aug 10, 2022
    Configuration menu
    Copy the full SHA
    d1cace5 View commit details
    Browse the repository at this point in the history
  10. Fix flags when using clang as linker for Fuchsia

    Don't add C runtime or set dynamic linker when linking with clang for
    Fuchsia. Clang already does this for us.
    tmandry committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    55d5dcb View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2022

  1. Simplify rustc_hir::intravisit::Visitor::visit_variant_data.

    It has four arguments that are never used. This avoids lots of argument
    passing in functions that feed into `visit_variant_data`.
    nnethercote committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    8c53038 View commit details
    Browse the repository at this point in the history
  2. Simplify rustc_ast::visit::Visitor::visit_enum_def.

    It's passed three arguments that are never used.
    nnethercote committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    421125f View commit details
    Browse the repository at this point in the history
  3. Simplify rustc_ast::visit::Visitor::visit_poly_trait_ref.

    It is passed an argument that is never used.
    nnethercote committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    232bd80 View commit details
    Browse the repository at this point in the history
  4. Simplify rustc_hir::intravisit::Visitor::visit_enum_def.

    It is passed an argument that is never used.
    nnethercote committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b8b851f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ce78042 View commit details
    Browse the repository at this point in the history
  6. more typos

    Co-authored-by: Nicholas Nethercote <[email protected]>
    RalfJung and nnethercote authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    338d7c2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    121fab0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    8bbb54a View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#99337 - jsha:simplify-highlight, r=Guillaum…

    …eGomez
    
    rustdoc: simplify highlight.rs
    
    Split render_with_highlighting, which took many optional parameters, into three functions for specific purposes, which each take a smaller number of mostly required parameters.
    
    Remove some plumbing to pass through an "edition" parameter, which was used solely to avoid highlighting some 2021 Edition keywords in non-2021 code.
    
    I've tested a build of std docs before and after, and this does not change the generated HTML at all.
    
    Followup from rust-lang#91264 (comment)
    
    r? ```@GuillaumeGomez```
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    9606408 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#99421 - Bryanskiy:android-crt-static, r=pet…

    …rochenkov
    
    add crt-static for android
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6737549 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#99500 - tmandry:fuchsia-flags, r=petrochenkov

    Fix flags when using clang as linker for Fuchsia
    
    Don't add C runtime or set dynamic linker when linking with clang for
    Fuchsia. Clang already does this for us.
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    92b32e3 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#99511 - RalfJung:raw_eq, r=wesleywiser

    make raw_eq precondition more restrictive
    
    Specifically, don't allow comparing pointers that way. Comparing pointers is subtle because you have to talk about what happens to the provenance.
    
    This matches what [Miri already implements](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=9eb1dfb8a61b5a2d4a7cee43df2717af), and all existing users are fine with this.
    
    If raw_eq on pointers is ever desired, we can adjust the intrinsic spec and Miri implementation as needed, but for now that seems just unnecessary. Also, this is a const intrinsic, and in const, comparing pointers this way is *not possible* -- so if we allow the intrinsic to compare pointers in general, we need to impose an extra restrictions saying that in const-context, pointers are *not* okay.
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    37efd55 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#99992 - jyn514:shell-scripts, r=Mark-Simula…

    …crum
    
    Add `x.sh` and `x.ps1` shell scripts
    
    This is a more ambitious version of rust-lang#98716.
    It still changes the x.py shebang back to python3, for compatibility with non-Unix systems,
    but also adds alternative entrypoints for systems without `python3` installed.
    
    These scripts will be necessary for the rust entrypoint (rust-lang#94829), so I see
    little downside in adding them early.
    
    I'll update the dev-guide to suggest using these instead of x.py once this is merged.
    
    Fixes rust-lang#98650
    
    r? `@Mark-Simulacrum` cc `@dtolnay` `@CAD97` `@yoshuawuyts`
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    20f124a View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#100112 - RalfJung:assert_send_and_sync, r=m…

    …-ou-se
    
    Fix test: chunks_mut_are_send_and_sync
    
    Follow-up to rust-lang#100023 to make the test actually effective
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    275d4e7 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#100203 - compiler-errors:command-args-size-…

    …hint, r=m-ou-se
    
    provide correct size hint for unsupported platform `CommandArgs`
    
    Split from rust-lang#99880 (comment)
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bd64d67 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e221aaf View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#100350 - jhpratt:stringify-vis, r=cjgillot

    Stringify non-shorthand visibility correctly
    
    This makes `stringify!(pub(in crate))` evaluate to `pub(in crate)` rather than `pub(crate)`, matching the behavior before the `crate` shorthand was removed. Further, this changes `stringify!(pub(in super))` to evaluate to `pub(in super)` rather than the current `pub(super)`. If the latter is not desired (it is _technically_ breaking), it can be undone.
    
    Fixes rust-lang#99981
    
    `@rustbot` label +C-bug +regression-from-stable-to-beta +T-compiler
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    6ae0414 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#100374 - GuillaumeGomez:improve_rustdoc_sea…

    …rch_results_page_crates_selection, r=notriddle
    
    Improve crate selection on rustdoc search results page
    
    Take over of rust-lang#98855 (screenshots and explanations are there).
    
    You can test it [here](https://rustdoc.crud.net/imperio/improve_rustdoc_search_results_page_crates_selection/std/index.html?search=test).
    
    cc ``@steffahn`` ``@jsha``
    r? ``@notriddle``
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    cefcfda View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#100392 - nnethercote:simplify-visitors, r=c…

    …jgillot
    
    Simplify visitors
    
    By removing some unused arguments.
    
    r? `@cjgillot`
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    8237efc View commit details
    Browse the repository at this point in the history
  20. Rollup merge of rust-lang#100418 - tbodt:stabilize-backtrace, r=dtolnay

    Add stability attributes to BacktraceStatus variants
    
    Fixes rust-lang#100399
    matthiaskrgr authored Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c7578b4 View commit details
    Browse the repository at this point in the history