Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: make item-infos dimmer on dark theme #93896

Merged
merged 1 commit into from
Aug 12, 2022
Merged

rustdoc: make item-infos dimmer on dark theme #93896

merged 1 commit into from
Aug 12, 2022

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Feb 11, 2022 •
edited
Loading

Previously the item-info background colors were too bright for a dark theme, making a bright rectangle that draws the attention.

Demo:

https://rustdoc.crud.net/jsha/dark-colors/std/os/linux/process/struct.PidFd.html
https://rustdoc.crud.net/jsha/dark-colors/std/error/trait.Error.html#method.description

Before:

After:

r? @GuillaumeGomez

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc labels Feb 11, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 11, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member

I find it much harder to read. The text color is too "close" to the background color I think.

@jsha
Copy link
Contributor Author

jsha commented Feb 12, 2022

Is it specifically the unstable yellow that's hard to read? Or all the colors? Would darkening that yellow help?

Also, started a Zulip thread: https://rust-lang.zulipchat.com/#narrow/stream/266220-rustdoc/topic/bright.20boxes.20in.20dark.20theme

@GuillaumeGomez
Copy link
Member

I'd say both actually.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2022
@bors
Copy link
Contributor

bors commented Jun 6, 2022

☔ The latest upstream changes (presumably #97783) made this pull request unmergeable. Please resolve the merge conflicts.

@jsha jsha mentioned this pull request Jul 26, 2022
Open
@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2022

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

@jsha
Copy link
Contributor Author

jsha commented Jul 27, 2022

Per the discussion in Zulip (linked above) I've adopted the blue-ish color used in Ayu into the dark theme. I've updated the demo and the screenshot in the first post.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member

I really like this change for the dark theme! Should we do something similar for the light theme? That would simplify the CSS quite a lot.

@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2022

A change occurred in the Ayu theme.

cc @Cldfire

@GuillaumeGomez
Copy link
Member

It looks great! If the PR is ready, then r=me once CI pass.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jsha
rustdoc: make item-infos dimmer on dark theme rust-lang#93896
20cc5f9 
Previously the item-info background colors were too bright for a dark
theme, making a bright rectangle that draws the attention.
@jsha
Copy link
Contributor Author

jsha commented Aug 11, 2022

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Aug 11, 2022

📌 Commit 20cc5f9 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 11, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 11, 2022
@bors
Auto merge of rust-lang#100426 - matthiaskrgr:rollup-0ks4dou, r=matth…
2ed0f29 
…iaskrgr

Rollup of 13 pull requests

Successful merges:

 - rust-lang#93896 (rustdoc: make item-infos dimmer on dark theme)
 - rust-lang#99337 (rustdoc: simplify highlight.rs)
 - rust-lang#99421 (add crt-static for android)
 - rust-lang#99500 (Fix flags when using clang as linker for Fuchsia)
 - rust-lang#99511 (make raw_eq precondition more restrictive)
 - rust-lang#99992 (Add `x.sh` and `x.ps1` shell scripts)
 - rust-lang#100112 (Fix test: chunks_mut_are_send_and_sync)
 - rust-lang#100203 (provide correct size hint for unsupported platform `CommandArgs`)
 - rust-lang#100307 (Fix rust-lang#96847)
 - rust-lang#100350 (Stringify non-shorthand visibility correctly)
 - rust-lang#100374 (Improve crate selection on rustdoc search results page)
 - rust-lang#100392 (Simplify visitors)
 - rust-lang#100418 (Add stability attributes to BacktraceStatus variants)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8bbb54a into rust-lang:master Aug 12, 2022
@rustbot rustbot added this to the 1.65.0 milestone Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-rustdoc-themes Area: Themes for HTML pages generated by rustdoc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.65.0
Development

Successfully merging this pull request may close these issues.
7 participants
@jsha @rust-highfive @rust-log-analyzer @GuillaumeGomez @bors @rustbot @JohnCSimon