Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename core::private #4743

Closed
brson opened this issue Feb 1, 2013 · 4 comments
Closed

Rename core::private #4743

brson opened this issue Feb 1, 2013 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Milestone
0.7

Comments

@brson
Copy link
Contributor

brson commented Feb 1, 2013

This is a public module of things that are exported by core but should not be considered part of the stable library interface. Some don't like the name, and indeed it's name is the opposite of it's form.

What should it be renamed to?
@brson brson mentioned this issue Feb 1, 2013
Closed
@Kimundi
Copy link
Member

Kimundi commented Feb 1, 2013

Internal, implspecific, dontusethis, unstable, changeable, corehacks?

@z0w0
Copy link
Contributor

z0w0 commented Feb 10, 2013

back?

@graydon
Copy link
Contributor

graydon commented Feb 10, 2013

I like "unstable"; can imagine the future bug report about it changing unexpectedly...

@brson
Copy link
Contributor Author

brson commented Feb 10, 2013

'unstable' sounds good to me to.

brson added a commit to brson/rust that referenced this issue Mar 1, 2013
@brson
Rename core::private to core::unstable. rust-lang#4743
9e320b9
brson added a commit to brson/rust that referenced this issue Mar 1, 2013
@brson
Rename core::private to core::unstable. rust-lang#4743
bcf6268
@brson brson closed this as completed Mar 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
4 participants
@graydon @brson @z0w0 @Kimundi