Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split core::pipes into core::comm and core::rt::pipes #4742

Closed
brson opened this issue Feb 1, 2013 · 3 comments
Closed

Split core::pipes into core::comm and core::rt::pipes #4742

brson opened this issue Feb 1, 2013 · 3 comments
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Feb 1, 2013

The end-user parts, stream, Chan, Port, etc. become the new comm. The rest can hide with other runtime code (#2240) in core::rt::pipes. We maybe don't want the implementation details to have a stable interface yet.
@brson
Copy link
Contributor Author

brson commented Feb 1, 2013

core::rt is priv so at least some of the pipe module would still need to be reexported from core::private, or whatever it gets called (#4743).

@brson
Copy link
Contributor Author

brson commented Feb 2, 2013

I don't think we need to move pipes to core::rt after all. Instead make it private and reexport the compiler interface under core::internal (or private or whatever it turns out to be).

brson added a commit to brson/rust that referenced this issue Feb 22, 2013
@brson
core: Extract comm from pipes. rust-lang#4742
dab6a85
@brson
Copy link
Contributor Author

brson commented Jun 27, 2013

Done.

@brson brson closed this as completed Jun 27, 2013
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 28, 2019
@matthiaskrgr
submodules: update clippy from 66df92a to c8e3cfb
f9ac609 
Changes:
````
travis: temporarily disable rustfmt ci check until rust-lang#4742 is resolved
rustup rust-lang#65792
Fix ICE rust-lang#4579
Add regression test for ICE rust-lang#4579
Run update_lints for Unicode lint
Re-add false positive check
Add raw string regression test for useless_format lint
Re-factor useless_format lint
Update Unicode lint tests
[Backported] Rustup to rust-lang#59545
````

Fixes #rust-lang#65888
bors added a commit that referenced this issue Oct 29, 2019
@bors
Auto merge of #65904 - matthiaskrgr:submodule_upd, r=Manishearth
caa1f8d 
submodules: update clippy from 66df92a to c8e3cfb

Changes:
````
travis: temporarily disable rustfmt ci check until #4742 is resolved
rustup #65792
Fix ICE #4579
Add regression test for ICE #4579
Run update_lints for Unicode lint
Re-add false positive check
Add raw string regression test for useless_format lint
Re-factor useless_format lint
Update Unicode lint tests
[Backported] Rustup to #59545
````

Fixes #65888

r? @oli-obk @Manishearth
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson