Add ICEs to Glacier #29249
Comments
steveklabnik
added
E-easy
|
I don't know how to reproduce #29249 on CI, as it requires a PII computer apparently. |
|
@bltavares you appear to have linked to this issue itself? |
|
@bltavares hmmm, yes, that's a tough one. Maybe it's too much effort, and should just be checked off the list? |
|
@steveklabnik I think it makes sense to be checked here. What about adding a note to skip certain ICEs on Glacier? |
|
I checked it off and left a note. |
|
#15522 is a Windows bug and the initial files used to report the issue are not available anymore. |
|
#18937 Does not produce ICE, but is unsound according to the discussion and would better produce ICE. |
|
#18953 Is stale and needs test case. Was initially found on Zinc. |
|
#19497 Has no code to reproduce. Not sure what to do over there. |
|
#19500 Has no code to reproduce. |
|
#19635 Has no code to reproduce. |
|
#19675 has been closed already. |
|
#26886 Doesn't seem to be an issue anymore and is marked with E-needstest |
|
Thank you both for all of your work here! This is great 💯 |
|
@steveklabnik Thanks for showing a simple way to contribute back. (: |
|
#20767 Is stale and needs a compiling example |
|
#21275 Is stale and needs an example code |
|
#21321 The author says it could have been fixed already, but the author is not sure (nor am I) |
|
#21349 Is stale and needs a small reproducible example. |
|
This one has been closed #24957 |
|
#24947 No loger ICE |
|
#23370 has been closed already. |
|
#23003 has been closed. |
|
https://github.com/steveklabnik/glacier/blob/master/src/27954.rs appears to have been added but not marked as such |
|
#24956 is incorrectly marked; this issue was never resolved and is reopened. |
|
whoops! must have messed that up :( |
|
I'll take on a couple if someone can mentor, I really want to learn me some more Rust by contributing to Rust. 😄 |
|
@wldcordeiro sure thing! Basically, pick one of the unchecked things, find the code that causes the compiler to crash, and then make a PR to steveklabnik/glacier that looks like this: https://github.com/steveklabnik/glacier/blob/master/src/15694.rs File name is the issue number, and it's just the code. I can help with any questions if you need any of that explained further, or I can help in real time if you drop by IRC. |
|
Thank you! Checked those off the list. |
|
I did a pass on the remaining issues in the list. All of them are non-trivial to add to the current way the tests are being done now and can't be reproduced with a single source file. So I'm not sure what would be the best way to proceed on the remaining issues without trying to make the testing script a bit more advanced (needs to be able to clone stuff on git, run cargo, or compile with rustc using specific flags to trigger issues in some cases) |
|
Seems that #29052 is closed now |
|
This list is basically done, I think; the remaining ones are not automatable. Thanks everyone! |
My Glacier repository is tracking our ICEs. Once per day, a Travis build confirms that the example still causes an ICE.
@Manishearth suggested I make a metabug here, so if you're looking for an easy way to contribute, this is it! I'm willing to mentor anyone who needs help.
https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AI-ICE is the list of bugs. Here's a tracking list of which ones that have been added:
typeof#29184debug = trueandlto = true. #28557-C prefer-dynamiccauses LLVM error #28434(left == right)(left:..., right:...)', ../src/librustc_borrowck/borrowck/mod.rs:453 #28150advapi32-syson a network-mapped drive #28002(left == right)(left:collections::string::String, right:Box<Int>)', ../src/librustc_borrowck/borrowck/mod.rs:453 #27844...has already been imported in this module. #26886Unimplemented... (trait objects & associated type bounds) #26406static mut#26263Unimplementedwhen trying to select an implementation for constant trait item reference. #26095Selfin inherent impl on trait #25050UnimplementedselectingBinder(...)#24294Obligation(...)andProjectionPredicate(...)in projection #24204<_ as core::iter::Iterator>::Item#23707UnimplementedselectingBinder(core::iter::IntoIterator)during trans #23281Box<Any>#22713pub use super::*in public inner mod. #21601$cratein macro #20753extern "rust-call"function #19397(left == right) && (right == left)(left:11, right:0) #16763rustc --version | false#14505The text was updated successfully, but these errors were encountered: