Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename logic_bug to overly_complex_bool_expr #9306

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Rename logic_bug to overly_complex_bool_expr #9306

merged 1 commit into from
Aug 8, 2022

Conversation

guerinoni
Copy link
Contributor

@guerinoni guerinoni commented Aug 8, 2022

Closes #1916

changelog: Rename logic_bug to [overly_complex_bool_expr]

@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 8, 2022
@llogiq
Copy link
Contributor

llogiq commented Aug 8, 2022

Thank you!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 8, 2022

📌 Commit 2752f49 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 8, 2022

⌛ Testing commit 2752f49 with merge 252d77f...

bors added a commit that referenced this pull request Aug 8, 2022
Rename `logic_bug` to `overly_complex_bool_expr`

Closes #1916
@bors
Copy link
Collaborator

bors commented Aug 8, 2022

💔 Test failed - checks-action_test

@xFrednet
Copy link
Member

xFrednet commented Aug 8, 2022

LGTM, also added a changelog entry. Thank you!

@bors r=llogiq,xFrednet

@bors
Copy link
Collaborator

bors commented Aug 8, 2022

📌 Commit f6cab94 has been approved by llogiq,xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Aug 8, 2022

⌛ Testing commit f6cab94 with merge 8f39061...

@guerinoni
Copy link
Contributor Author

@xFrednet thanks 🙏

@bors
Copy link
Collaborator

bors commented Aug 8, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq,xFrednet
Pushing 8f39061 to master...

@bors bors merged commit 8f39061 into rust-lang:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename logic_bug
5 participants