Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename logic_bug #1916

Closed
Manishearth opened this issue Aug 1, 2017 · 5 comments · Fixed by #9306
Closed

Rename logic_bug #1916

Manishearth opened this issue Aug 1, 2017 · 5 comments · Fixed by #9306
Labels
good-first-issue These issues are a good way to get started with Clippy S-needs-discussion Status: Needs further discussion before merging or work can be started
Milestone
1.0

Comments

@Manishearth
Copy link
Member

http://rust-lang-nursery.github.io/rust-clippy/master/#logic_bug

Probably should be called "logical_op_bug" or something.

"logic bug" is a more general term that has to do with a bug in the higher level logic of a program.
@Manishearth Manishearth added S-needs-discussion Status: Needs further discussion before merging or work can be started C-1.0-blocking labels Aug 1, 2017
@oli-obk
Copy link
Contributor

oli-obk commented Aug 1, 2017

  • broken_bool_expr
  • inconsistent_bool_expr

@oli-obk oli-obk added this to the 1.0 milestone Mar 30, 2018
@oli-obk oli-obk added good-first-issue These issues are a good way to get started with Clippy and removed C-1.0-blocking labels Mar 30, 2018
@phansch
Copy link
Member

phansch commented Apr 2, 2018

The lint only seems to be about checking non-simplified boolean expressions, right? How about non_simplified_bool_expr or non_minimized_bool_expr?

@dwijnand
Copy link
Member

dwijnand commented Jul 5, 2018

There's already another lint called nonminimal_bool, which is categorised as "complexity", while this one is categorised as "correctness".

If a name can be found I'd be happy to resolve this and move 1.0 that little bit closer.

@flip1995 flip1995 mentioned this issue Jan 15, 2020
Closed
@guerinoni
Copy link
Contributor

What is the status of this? Can I rename to non_minimized_bool_expr?

@xFrednet
Copy link
Member

xFrednet commented Aug 7, 2022

I think there is no real status. If we find a better name we can just rename the lint. (We have a command for that in clippy dev)

The suggested lint name sounds like a double negotiation with non_minimalized.. what do you think about overly_complex_bool_expr. Even if that's not perfect jet. It might be good to ask the on our zulip, there are some magicians when to comes to finding lint names :)

@guerinoni guerinoni mentioned this issue Aug 8, 2022
Merged
bors added a commit that referenced this issue Aug 8, 2022
@bors
Auto merge of #9306 - guerinoni:rename-logic-bug, r=llogiq
252d77f 
Rename `logic_bug` to `overly_complex_bool_expr`

Closes #1916
bors added a commit that referenced this issue Aug 8, 2022
@bors
Auto merge of #9306 - guerinoni:rename-logic-bug, r=llogiq,xFrednet
8f39061 
Rename `logic_bug` to `overly_complex_bool_expr`

Closes #1916

changelog: Rename `logic_bug` to [`overly_complex_bool_expr`]
@bors bors closed this as completed in f6cab94 Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue These issues are a good way to get started with Clippy S-needs-discussion Status: Needs further discussion before merging or work can be started
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Rename logic_bug to overly_complex_bool_expr
6 participants
@oli-obk @dwijnand @Manishearth @phansch @xFrednet @guerinoni