Add needless_late_init lint

[Alexendoo]

examples:

let a;
a = 1;
// to
let a = 1;

let b;
match 3 {
    0 => b = "zero",
    1 => b = "one",
    _ => b = "many",
}
// to
let b = match 3 {
    0 => "zero",
    1 => "one",
    _ => "many",
};

let c;
if true {
    c = 1;
} else {
    c = -1;
}
// to
let c = if true {
    1
} else {
    -1
};

changelog: Add [needless_late_init]

[rust-highfive]

r? @giraffate

(rust-highfive has picked a reviewer for you, use r? to override)

[Alexendoo]

This overlaps a little with useless_let_if_seq, needless_late_init doesn't do as many clever transformations as useless_let_if_seq however, hopefully meaning it has less false positives

I wasn't sure what to choose here, I could remove the matching of ifs from needless_late_init

[giraffate]

This overlaps a little with useless_let_if_seq, needless_late_init doesn't do as many clever transformations as useless_let_if_seq however, hopefully meaning it has less false positives

Yes, it looks good.

I wasn't sure what to choose here, I could remove the matching of ifs from needless_late_init

IMO it looks good as it is.

[Alexendoo]

Another problem I had was with mutlispan_suggest, the suggestions are a little bare and using _verbose doesn't seem to change it. As well as running into rust-lang/rustfix#141

Is there a way to have a regular suggestion appear just without the help label repeated?

[bors]

☔ The latest upstream changes (presumably #7977) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #8007) made this pull request unmergeable. Please resolve the merge conflicts.

[giraffate]

Overall looks good, thanks! I made some small comments.

[Alexendoo]

Thanks, made the changes

[giraffate]

@bors r+

Thanks!

[bors]

📌 Commit d346ec9 has been approved by giraffate

[bors]

⌛ Testing commit d346ec9 with merge 3720735...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: giraffate
Pushing 3720735 to master...