Improve needless_borrow lint
#7977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Jarcho
force-pushed
the
multi_needless_borrow
branch
from
f26073b
to
29aea33
Compare
* Lint when a borrow is auto dereferenced more than once * Lint when the expression is used as the expression of a block for a match arm Moves `needless_borrow` and `ref_binding_to_reference` to `dereference` lint pass in preperation for `explicit_auto_deref` lint.
Jarcho
force-pushed
the
multi_needless_borrow
branch
from
29aea33
to
8ded385
Compare
xFrednet
approved these changes
Nov 18, 2021
|
Looks good to me. The code is nicely constructed, good job 👍 @bors r+ |
|
📌 Commit 8ded385 has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5327
fixes: #1726
fixes: #1212
This is merging
needless_borrowinto thedereferencepass in preparation forexplicit_auto_deref.explicit_auto_derefneeds to implement most of whatneedless_borrowimplements in order to work.There is a minor regression here where
let x: &str = &x.deref()will triggerneedless_borrowwithout triggeringexplicit_deref_methods. Removing the redundant borrow will causeexplicit_deref_methodsto trigger. This will be fixed whenexplicit_auto_derefis implemented.changelog: Lint
needless_borrowwhen a borrow is auto-derefed more than oncechangelog: Lint
needless_borrowin the trailing expression of a block for a match arm