Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests/ui/deprecated.rs #7885

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

devonhollowood
Copy link
Contributor

Clean up tests/ui/deprecated.rs

Along with #7884, this fixes #7057

changelog: none

This also removes the uplifted lints from this test suite -- these are now
tested in `tests/ui/rename.rs`
@rust-highfive
Copy link

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 26, 2021
@@ -1,106 +1,100 @@
error: lint `clippy::unstable_as_slice` has been removed: `Vec::as_slice` has been stabilized in 1.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this no longer tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is -- line 21 of the new .stderr file. I changed the order to be the same as the order in clippy_lints/src/deprecated_lints.rs (and the generated clippy_lints/src/lib.deprecated.rs). Sorry for the confusing diff this time, but hopefully imposing order here will lead to future diffs being easier to read.

That said, I did remove several tests from this file, because after #7884 they are tested in tests/ui/rename.rs

@llogiq
Copy link
Contributor

llogiq commented Oct 27, 2021

Thank you! @bors r+

@bors
Copy link
Collaborator

bors commented Oct 27, 2021

📌 Commit e48ab44 has been approved by llogiq

@bors
Copy link
Collaborator

bors commented Oct 27, 2021

⌛ Testing commit e48ab44 with merge ed71add...

@bors
Copy link
Collaborator

bors commented Oct 27, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing ed71add to master...

@bors bors merged commit ed71add into rust-lang:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up tests/ui/rename.rs and tests/ui/deprecated.rs
4 participants