-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up tests/ui/deprecated.rs
#7885
Conversation
This also removes the uplifted lints from this test suite -- these are now tested in `tests/ui/rename.rs`
r? @llogiq (rust-highfive has picked a reviewer for you, use r? to override) |
@@ -1,106 +1,100 @@ | |||
error: lint `clippy::unstable_as_slice` has been removed: `Vec::as_slice` has been stabilized in 1.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this no longer tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is -- line 21 of the new .stderr
file. I changed the order to be the same as the order in clippy_lints/src/deprecated_lints.rs
(and the generated clippy_lints/src/lib.deprecated.rs
). Sorry for the confusing diff this time, but hopefully imposing order here will lead to future diffs being easier to read.
That said, I did remove several tests from this file, because after #7884 they are tested in tests/ui/rename.rs
Thank you! @bors r+ |
📌 Commit e48ab44 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Clean up
tests/ui/deprecated.rs
Along with #7884, this fixes #7057
changelog: none