Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up tests/ui/rename.rs and tests/ui/deprecated.rs #7057

Closed
flip1995 opened this issue Apr 9, 2021 · 2 comments · Fixed by #7885
Closed

Clean up tests/ui/rename.rs and tests/ui/deprecated.rs #7057

flip1995 opened this issue Apr 9, 2021 · 2 comments · Fixed by #7885
Assignees
@devonhollowood
Labels
E-needs-test Call for participation: writing tests good-first-issue These issues are a good way to get started with Clippy

Comments

@flip1995
Copy link
Member

flip1995 commented Apr 9, 2021 •
edited by rustbot
Loading

When adding register_renamed or register_removed "lints" to Clippy, they should get tested in tests/ui/rename.rs or tests/ui/deprecated.rs respectively.

But since no one really put effort into maintaining those tests files they're all mixed up and lacking tests of some lints. This should be cleaned up, so that we have regression tests for all of our renamed/removed lints.
@flip1995 flip1995 added good-first-issue These issues are a good way to get started with Clippy E-needs-test Call for participation: writing tests labels Apr 9, 2021
@devonhollowood
Copy link
Contributor

I can take a look at this.

@devonhollowood
Copy link
Contributor

@rustbot claim

This was referenced Oct 26, 2021
Merged
Merged
bors added a commit that referenced this issue Oct 26, 2021
@bors
Auto merge of #7884 - devonhollowood:rename-cleanup, r=xFrednet
a48367e 
Clean up tests/ui/rename.rs

Part one of #7057, cleaning up `tests/ui/rename.rs`. `tests/ui/deprecated.rs` will be updated in a subsequent PR.

changelog: none
@bors bors closed this as completed in ed71add Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devonhollowood devonhollowood

Labels
E-needs-test Call for participation: writing tests good-first-issue These issues are a good way to get started with Clippy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean up tests/ui/deprecated.rs devonhollowood/rust-clippy
2 participants
@devonhollowood @flip1995