add #4546 test #7679
Merged
add #4546 test #7679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
xFrednet
reviewed
Sep 18, 2021
There was a problem hiding this comment.
Seems like the issue is already fixed. Thank you for adding a test for it. 👍
One more thing, the lint documentation has a list of rules with some limitations listed below, could you also add the fact that Pin<> is allowed around the self reference (probably worded a bit better) 🙃
lengyijun
force-pushed
the
issue4546
branch
from
debe02e to
79ece2a
Compare
xFrednet
reviewed
Sep 19, 2021
lengyijun
force-pushed
the
issue4546
branch
from
79ece2a to
b68325e
Compare
xFrednet
approved these changes
Sep 22, 2021
|
LGTM, thank you for adding the tests and documentation 🙃 @bors r+ |
|
📌 Commit b68325e has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none
fixed #4546
I notice #4546 was fixed some time, I just add the tests.