Skip to content

Commit

Permalink
Auto merge of #7679 - lengyijun:issue4546, r=xFrednet
Browse files Browse the repository at this point in the history
add #4546 test

changelog: none
fixed #4546

I notice #4546 was fixed some time, I just add the tests.
  • Loading branch information
bors committed Sep 22, 2021
2 parents 8a75002 + b68325e commit a4a8ec2
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 0 deletions.
2 changes: 2 additions & 0 deletions clippy_lints/src/methods/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,8 @@ declare_clippy_lint! {
/// The method signature is controlled by the trait and often `&self` is required for all types that implement the trait
/// (see e.g. the `std::string::ToString` trait).
///
/// Clippy allows `Pin<&Self>` and `Pin<&mut Self>` if `&self` and `&mut self` is required.
///
/// Please find more info here:
/// https://rust-lang.github.io/api-guidelines/naming.html#ad-hoc-conversions-follow-as_-to_-into_-conventions-c-conv
///
Expand Down
18 changes: 18 additions & 0 deletions tests/ui/wrong_self_convention2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,21 @@ mod issue3414 {
}
}
}

// don't trigger
mod issue4546 {
use std::pin::Pin;

struct S;
impl S {
pub fn as_mut(self: Pin<&mut Self>) {}

pub fn as_other_thingy(self: Pin<&Self>) {}

pub fn is_other_thingy(self: Pin<&Self>) {}

pub fn to_mut(self: Pin<&mut Self>) {}

pub fn to_other_thingy(self: Pin<&Self>) {}
}
}

0 comments on commit a4a8ec2

Please sign in to comment.