Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move needless_borrow to style #7254

Merged
merged 1 commit into from
May 21, 2021
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented May 20, 2021

fixes: #3742

#7105 should be merged first to fix the false positive.

changelog: move needless_borrow from nursery to style

@rust-highfive
Copy link

r? @Manishearth

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 20, 2021
@Jarcho Jarcho force-pushed the needless_borrow_2 branch from 1b9da07 to cfc2554 Compare May 20, 2021 13:24
@bors
Copy link
Contributor

bors commented May 21, 2021

☔ The latest upstream changes (presumably #7105) made this pull request unmergeable. Please resolve the merge conflicts.

@Jarcho Jarcho force-pushed the needless_borrow_2 branch from cfc2554 to f355aeb Compare May 21, 2021 15:25
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 21, 2021

📌 Commit f355aeb has been approved by Manishearth

@bors
Copy link
Contributor

bors commented May 21, 2021

⌛ Testing commit f355aeb with merge f694f85...

@bors
Copy link
Contributor

bors commented May 21, 2021

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing f694f85 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needless_borrow was temporarily moved to nursery in April 2018
4 participants