Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

needless_borrow was temporarily moved to nursery in April 2018 #3742

Closed
phansch opened this issue Feb 6, 2019 · 1 comment · Fixed by #7254
Closed

needless_borrow was temporarily moved to nursery in April 2018 #3742

phansch opened this issue Feb 6, 2019 · 1 comment · Fixed by #7254
Labels
C-question Category: Questions

Comments

@phansch
Copy link
Member

phansch commented Feb 6, 2019

In 0692b2b, the needless_borrow lint was temporarily moved to the nursery. However, it's still in the nursery now.

@oli-obk Since you committed that, do you maybe remember why you moved it to nursery and if it can be moved back? I couldn't find any other issues or PRs related to this commit unfortunately.

@phansch phansch added the C-question Category: Questions label Feb 6, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Feb 6, 2019

I moved it there because we were having problems after some proc macro changes that caused the lint to trigger inside derives without us being able to detect that. If this has been resolved, there's no reason not to move it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-question Category: Questions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants