Rollup of 9 pull requests #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy-driver: pass all args to rustc if --rustc is present changelog: clippy-driver: pass all args to rustc if --rustc is present
Downgrade unnested_or_patterns to pedantic Even with rust-lang#5704 fixed, I don't believe it is a safe bet that if someone is using or-patterns anywhere in a codebase then they want to use it as much as possible in the whole codebase. I think it would be reasonable to reevaluate after the feature is stable. I feel that a warn-by-default lint suggesting use of an unstable feature, even if already being used in one place, is questionable. changelog: Remove unnested_or_patterns from default set of enabled lints
Fix ICE in consts::binop changelog: Fix ICE in `consts::binop` Fixes rust-lang#5389
typo changelog: none
Remove `bar` from blacklisted names changelog: Remove `bar` from blacklisted names fixes rust-lang#5225
Use lints in Clippy that are enabled in rustc bootstrap cc rust-lang/rust#73297 (comment) changelog: none
Fix typo in wildcard_imports changelog: none
…anishearth redundant_pattern_matching: avoid non-`const fn` calls in const contexts changelog: Avoid suggesting non-`const fn` calls in const contexts in [`redundant_pattern_matching`] Fixes rust-lang#5697
Fix typo changelog: extending it's lifetime -> extending its lifetime
|
@bors r+ p=10 |
|
📌 Commit e4cbd1d has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
barfrom blacklisted names #5712 (Removebarfrom blacklisted names)const fncalls in const contexts #5724 (redundant_pattern_matching: avoid non-const fncalls in const contexts)Failed merges:
r? @ghost
changelog: rollup