Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redundant_pattern_matching: avoid non-const fn calls in const contexts #5724

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

ebroto
Copy link
Member

@ebroto ebroto commented Jun 16, 2020

changelog: Avoid suggesting non-const fn calls in const contexts in [redundant_pattern_matching]

Fixes #5697

@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 16, 2020
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 17, 2020

📌 Commit a7743e9 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Jun 17, 2020

⌛ Testing commit a7743e9 with merge 285353c...

bors added a commit that referenced this pull request Jun 17, 2020
redundant_pattern_matching: avoid non-`const fn` calls in const contexts

changelog: Avoid suggesting non-`const fn` calls in const contexts in [`redundant_pattern_matching`]

Fixes #5697
@bors
Copy link
Contributor

bors commented Jun 17, 2020

💔 Test failed - checks-action_test

@flip1995 flip1995 added S-waiting-on-bors Status: The marked PR was approved and is only waiting bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 22, 2020
@flip1995
Copy link
Member

@bors rollup

bors added a commit that referenced this pull request Jun 23, 2020
Rollup of 9 pull requests

Successful merges:

 - #5178 (clippy-driver: pass all args to rustc if --rustc is present)
 - #5705 (Downgrade unnested_or_patterns to pedantic)
 - #5709 (Fix ICE in consts::binop)
 - #5710 (typo)
 - #5712 (Remove `bar` from blacklisted names)
 - #5713 (Use lints in Clippy that are enabled in rustc bootstrap)
 - #5716 (Fix typo in wildcard_imports)
 - #5724 (redundant_pattern_matching: avoid non-`const fn` calls in const contexts)
 - #5726 (Fix typo)

Failed merges:

r? @ghost

changelog: rollup
@bors bors merged commit f562117 into rust-lang:master Jun 23, 2020
@ebroto ebroto deleted the 5697_const_result_option branch June 23, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: The marked PR was approved and is only waiting bors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redundant_pattern_matching suggests the use of non-const fn in const fn
5 participants