Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually add v0.0.191 docs #2619

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Manually add v0.0.191 docs #2619

merged 1 commit into from
Apr 3, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 3, 2018

After #2600 was fixed in 2a52527, the docs for v0.0.191 were not deployed automatically because the deploy script only deploys a new version page if the travis build is for a git tag.

I did this manually from my clippy fork checkout locally and hope that it's correct:

git checkout 2a52527 # The commit that fixed the lint generation issue

# Clone separate repo into /out to work with gh-pages branch
git clone [email protected]:rust-lang-nursery/rust-clippy.git out

cd out && git checkout gh-pages && cd -

mkdir out/v0.0.191

# Copy index.html template
cp util/gh-pages/index.html out/v0.0.191

# Generate lints.json from the current commit (2a52527) and save to out/v0.0.191/lints.json
python ./util/export.py out/v0.0.191/lints.json

# Manually add v0.0.191 to versions.json and copy stuff to main checkout

I didn't have time to review the lints.json yet, but would like to make sure that it doesn't contain things that were added after 2a52527 was fixed. (Have to do that later today)

Fixes #2614

@oli-obk oli-obk merged commit 3dca759 into rust-lang:gh-pages Apr 3, 2018
@oli-obk
Copy link
Contributor

oli-obk commented Apr 3, 2018

I didn't have time to review the lints.json yet, but would like to make sure that it doesn't contain things that were added after 2a52527 was fixed. (Have to do that later today)

Don't bother, if they were fixes, that's fine, if they are new lints, that's also fine ^^

@phansch
Copy link
Member Author

phansch commented Apr 3, 2018

Alright! :)

@phansch phansch deleted the gh-pages branch April 3, 2018 09:59
phansch added a commit to phansch/rust-clippy that referenced this pull request Apr 8, 2018
The travis build for the v0.0.192 tag failed and didn't run the
publishing step at the end.

See rust-lang#2614 and rust-lang#2619
phansch added a commit to phansch/rust-clippy that referenced this pull request Apr 8, 2018
The travis build for the v0.0.192 tag failed and didn't run the
publishing step at the end.

See rust-lang#2614 and rust-lang#2619
phansch added a commit to phansch/rust-clippy that referenced this pull request Apr 8, 2018
The travis build for the v0.0.192 tag failed and didn't run the
publishing step at the end.

See rust-lang#2614 and rust-lang#2619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants