Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The github.io links don't work for non-master releases if the Travis release build failed #2614

Closed
rcoh opened this issue Apr 2, 2018 · 11 comments
Labels
C-bug Category: Clippy is not doing the correct thing

Comments

@rcoh
Copy link
Contributor

rcoh commented Apr 2, 2018

Seems like a regression of #2223

warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
   --> src/lib.rs:241:19
    |
241 |             head: &Box<operator::AggregateOperator + 'a>,
    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&operator::AggregateOperator + 'a`
    |
    = note: #[warn(borrowed_box)] on by default
    = help: for further information visit https://rust-lang-nursery.github.io/rust-clippy/v0.0.191/index.html#borrowed_box
0.0.191

The links are accessible at .../master/...

@phansch phansch added the C-bug Category: Clippy is not doing the correct thing label Apr 3, 2018
@phansch
Copy link
Member

phansch commented Apr 3, 2018

@rcoh 191 doesn't work for me either. Does https://rust-lang-nursery.github.io/rust-clippy/v0.0.190/index.html#borrowed_box work for you? If yes, then probably #2600 only fixed the cause of the missing page, not the missing page itself.

@rcoh
Copy link
Contributor Author

rcoh commented Apr 3, 2018 via email

@phansch
Copy link
Member

phansch commented Apr 3, 2018

Thanks! I believe 191 didn't get pushed after #2600 was fixed. I will try and see if I can fix it manually.

@rcoh
Copy link
Contributor Author

rcoh commented Apr 3, 2018

See #2618 which may be related

@phansch
Copy link
Member

phansch commented Apr 3, 2018

Not sure why it didn't close automatically with the merge of #2619 🤷‍♂️

The 0.0.191 link works now :)

@phansch phansch closed this as completed Apr 3, 2018
@wmorgue
Copy link

wmorgue commented Apr 6, 2018

Same issue @phansch
Again 404 -> https://rust-lang-nursery.github.io/rust-clippy/v0.0.192/

λ ~/ cargo clippy -V
0.0.192

@rcoh
Copy link
Contributor Author

rcoh commented Apr 7, 2018

Yeah the 0.0.192 build failed https://travis-ci.org/rust-lang-nursery/rust-clippy/builds/362416150

@rcoh
Copy link
Contributor Author

rcoh commented Apr 7, 2018

Can you reopen @phansch ?

@phansch phansch reopened this Apr 8, 2018
@phansch
Copy link
Member

phansch commented Apr 8, 2018

Thanks, I'll publish them manually for now, but we probably need to change how we release clippy to prevent this from happening again.

phansch added a commit to phansch/rust-clippy that referenced this issue Apr 8, 2018
The travis build for the v0.0.192 tag failed and didn't run the
publishing step at the end.

See rust-lang#2614 and rust-lang#2619
@phansch phansch changed the title The github.io links don't work for non-master releases The github.io links don't work for non-master releases if the Travis release build failed Apr 8, 2018
phansch added a commit to phansch/rust-clippy that referenced this issue Apr 8, 2018
The travis build for the v0.0.192 tag failed and didn't run the
publishing step at the end.

See rust-lang#2614 and rust-lang#2619
phansch added a commit to phansch/rust-clippy that referenced this issue Apr 8, 2018
The travis build for the v0.0.192 tag failed and didn't run the
publishing step at the end.

See rust-lang#2614 and rust-lang#2619
@phansch
Copy link
Member

phansch commented Apr 8, 2018

The 0.0.192 docs work now and 0.0.193 has been released as well 🚀

@flip1995
Copy link
Member

Since we're not publishing versions anymore, I go ahead and close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Clippy is not doing the correct thing
Projects
None yet
Development

No branches or pull requests

4 participants