Add new lint: manual_assert_matches

[lcian]

Close #17111

changelog: [manual_assert_matches]: Add new lint: manual_assert_matches

[github-actions]

Lintcheck changes for 89f7a41

Lint	Added	Removed	Changed
clippy::manual_assert_matches	2	0	0

This comment will be updated if you push new changes

[samueltardieu]

I am not sure you need an early collector pass.

When you check an expression, if it comes from expansion, you can use first_node_macro_backtrace() from clippy_utils::macros to get the succession of macro calls. You can then match them against one of the *assert! macros (see is_assert_macro()), then against matches!() (by checking it is the right diagnostic item). This is much more robust than comparing strings.

View changes since this review

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[lcian]

Thank you @samueltardieu!
I wrongly assumed that not enough of the pre-expansion information would be contained in the HIR.
That's why I was pretty surprised to read that pre-expansion passes are considered deprecated (https://github.com/rust-lang/rust/blob/f8a08b688cbe60acc386ed1fbd1b7cbaaf5576b1/compiler/rustc_lint/src/context.rs#L175).
I'm now rewriting this using only a late pass, it seems that will be sufficient indeed.

[lcian]

@rustbot ready

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @samueltardieu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 8 candidates
• 8 candidates expanded to 8 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[rustbot]

☔ The latest upstream changes (possibly #15000) made this pull request unmergeable. Please resolve the merge conflicts.