add new lint: rest_when_destructuring_struct
#15000
Open
+458
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
Erk-
force-pushed
the
lint/rest_when_destructuring_struct
branch
from
1504461 to
4cdbec3
Compare
Centri3
reviewed
Jun 7, 2025
Erk-
force-pushed
the
lint/rest_when_destructuring_struct
branch
from
72913a1 to
a314686
Compare
|
Lintcheck changes for 7770ee6
This comment will be updated if you push new changes |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 24, 2025
…rors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Aug 24, 2025
…rors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
fmease
added a commit
to fmease/rust
that referenced
this pull request
Sep 1, 2025
…rors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 2, 2025
…rors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 2, 2025
…rors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Sep 2, 2025
Rollup merge of #145783 - Erk-:et-cetera-span, r=compiler-errors add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 3, 2025
add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Sep 4, 2025
add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
mohe2015
pushed a commit
to tucan-plus/rustfmt
that referenced
this pull request
Sep 6, 2025
add span to struct pattern rest (..) Struct pattern rest (`..`) did not retain span information compared to normal fields. This patch adds span information for it. The motivation of this patch comes from when I implemented this PR for Clippy: rust-lang/rust-clippy#15000 (comment) It is possible to get the span of the Et cetera in a bit roundabout way, but I thought this would be nicer.
This comment has been minimized.
This comment has been minimized.
Erk-
force-pushed
the
lint/rest_when_destructuring_struct
branch
from
6868cd5 to
b52ea0e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Erk-
force-pushed
the
lint/rest_when_destructuring_struct
branch
from
b52ea0e to
45d2dfa
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Alexendoo
reviewed
Oct 8, 2025
ada4a
reviewed
Oct 11, 2025
ada4a
reviewed
Oct 13, 2025
| let (_, end) = pat_search_pat(tcx, p); | ||
| (Pat::Str("box"), end) | ||
| }, | ||
| PatKind::Deref(_) => (Pat::Str("deref!("), Pat::Str(")")), |
There was a problem hiding this comment.
@Jarcho these parens should probably be removed, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new lint that warns when using a rest pattern when destructuring a struct. This lint was requested in this comment #10666 (comment) by @xxchan.
changelog: [
rest_when_destructuring_struct] new lint