Add collapse-let-chains option to collapsible_if lint
#14455
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This was referenced Mar 23, 2025
samueltardieu
force-pushed
the
push-xyxtzlqyuwxy
branch
3 times, most recently
from
cfb1562 to
bec2183
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
This PR enables the new ability to collapse `if` statements containing comments (without losing them) in Clippy sources, excluding tests and lintcheck, where the default behaviour (no collapsing in presence of comments) is preserved. To be applied after #14231. When it is applied, #14455 will be marked as ready for review, then #14228 afterwards. changelog: none r? ghost
Since `collapsible_if` is an early lint, it is not possible to automatically check whether the `let_chains` unstable rustc feature is enabled or not, as features are not available in the `EarlyContext` object. For this reason, the `collapse-let-chains` needs to be enabled explicitly. This can be reexamined later when the `let_chains` feature is stabilized.
samueltardieu
force-pushed
the
push-xyxtzlqyuwxy
branch
from
bec2183 to
dbfe15e
Compare
|
How difficult would it be to turn this into a late lint pass? |
I'll check when I get a chance. Originally, the lint used @rustbot author |
rustbot
added
S-waiting-on-author
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 28, 2025
Until `if let` chains are stabilized, we do not collapse them together or with other `if` expressions unless the `let_chains` feature is enabled. This is the case for example in Clippy sources. This was made possible by converting the `collapsible_if` to a late lint to get access to the set of enabled features. This allows this PR to supersede #14455 and no longer require an additional configuration option. The three commits are, in order: - a conversion of the existing early lint to a late lint, with no new feature or tests changes - the addition of the `let_chains` feature detection and action, and tests - the application of the enhanced lint to Clippy sources (136 files modified) changelog: [`collapsible_if`]: recognize the rust compiler `let_chains` feature r? @flip1995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
collapsible_ifis an early lint, it is not possible to automatically check whether thelet_chainsunstable rustc feature is enabled or not, as features are not available in theEarlyContextobject.For this reason, the
collapse-let-chainsneeds to be enabled explicitly. This can be reexamined later when thelet_chainsfeature is stabilized.changelog: [
collapsible_if]: addcollapse-let-chainsoptionr? ghost