Apply collapsible if to Clippy sources #14451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
force-pushed
the
apply-collapsible-if
branch
from
9c39dc5 to
7bcb664
Compare
samueltardieu
force-pushed
the
apply-collapsible-if
branch
from
7bcb664 to
9ec9a31
Compare
|
Rebased |
samueltardieu
force-pushed
the
apply-collapsible-if
branch
from
9ec9a31 to
bf329c5
Compare
flip1995
approved these changes
Mar 25, 2025
samueltardieu
force-pushed
the
apply-collapsible-if
branch
from
bf329c5 to
6509de3
Compare
|
I've repushed with the formatting issue you've identified @flip1995. I'm surprised that |
|
Yeah, for some reason sometimes it works and sometimes it doesn't 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the new ability to collapse
ifstatements containing comments (without losing them) in Clippy sources, excluding tests and lintcheck, where the default behaviour (no collapsing in presence of comments) is preserved.To be applied after #14231. When it is applied, #14455 will be marked as ready for review, then #14228 afterwards.
changelog: none
r? ghost