Add ignore_without_reason lint
#13931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
rustbot
added
the
S-waiting-on-review
smoelius
force-pushed
the
ignore-without-reason
branch
from
43088fe to
149177a
Compare
|
Re the EDIT: That check check is working again. |
smoelius
force-pushed
the
ignore-without-reason
branch
from
aad5ee5 to
44392b7
Compare
Alexendoo
added
S-final-comment-period
smoelius
force-pushed
the
ignore-without-reason
branch
from
44392b7 to
475d10d
Compare
|
I'd be fine with merging this as is, but how do you feel about the suggestion in the FCP to have this in |
Perfectly fine with me. :) |
Alexendoo
approved these changes
Mar 22, 2025
| /// #[ignore = "Some good reason"] | ||
| /// fn test() {} | ||
| /// ``` | ||
| #[clippy::version = "1.85.0"] |
There was a problem hiding this comment.
Should be 1.88.0, see #14653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13066 (tests that are ignored with no reason message).
changelog: Add
ignore_without_reasonlint